Skip to content

Ruby on Rails capstone project - Budget app#5

Open
VaneCode wants to merge 39 commits intomainfrom
dev
Open

Ruby on Rails capstone project - Budget app#5
VaneCode wants to merge 39 commits intomainfrom
dev

Conversation

@VaneCode
Copy link
Copy Markdown
Owner

@VaneCode VaneCode commented Nov 26, 2022

In this project the following requirements were implemented:

  • Added styles according to the design guidelines.
  • Created the splash screen.
  • Added sing up and login pages using Devise.
  • Created the home page to show categories.
  • Created a transaction page to show transactions that belong to a category.
  • Created a page to add a new category.
  • Created the page to add a new transaction.
  • Added tests.

This project was deployed on Render.

image

image

You can see a live video of this project.

You can log in using these credentials:

user's email: vanebonito@hotmail.com
password: 123456

Or you can create your own user.

Copy link
Copy Markdown

@afanimartin afanimartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @VaneCode,

Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights 🎉 🎉 🎉

  • Readme is professional
  • Code is clean and professional

Required Changes ♻️

Check the comments under the review.

  • I could not register a new user. I kept getting invalid email/password error even when the required information is provided. Please fix that error.
  • Running rspec to execute the test cases also throws an error. Make sure all errors are resolved before re-submitting the PR.
    Screenshot from 2022-11-26 08-45-34

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Martin Afani

Slack: whiz25


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@VaneCode
Copy link
Copy Markdown
Owner Author

Hi @VaneCode,

Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

  • Readme is professional
  • Code is clean and professional

Required Changes

Check the comments under the review.

  • I could not register a new user. I kept getting invalid email/password error even when the required information is provided. Please fix that error.
  • Running rspec to execute the test cases also throws an error. Make sure all errors are resolved before re-submitting the PR.
    Screenshot from 2022-11-26 08-45-34

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!clapclapclap

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Martin Afani

Slack: whiz25

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@VaneCode VaneCode closed this Nov 26, 2022
@VaneCode VaneCode reopened this Nov 26, 2022
@VaneCode
Copy link
Copy Markdown
Owner Author

Helllo @afanimartin ,
Thanks for your review, I am working on the issue with the login. But could you help me with the problem with RSpec, the tests are successful when I run them. So, there is a possibility that the problem was a missing gem in your local environment?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants