Harden Sage editing and deterministic QA workflows#85
Draft
Valorith wants to merge 7 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Sage visual and editor regressions were difficult to reproduce reliably because validation depended on manual inspection, fixed timing, and incomplete model/appearance coverage. The new tooling gives developers a repeatable production-surface workflow for verifying appearance variants, animations, model framing, spawn edits, door placement, and resource stability.
Impact
Developers can now inspect models as they render in Spire, focus on faces, exercise editor lifecycles, and capture stable evidence through one QA runner. Runtime changes are scoped and validated to avoid changing correctly authored models.
Root cause
The affected workflows lacked stable readiness contracts and semantic visual invariants. In particular, prior head-orientation checks covered texture state and gross bounds but could not distinguish a valid Iksar head from a damaging whole-head rotation.
Validation