feat: embed_qr + QR placement contract (v1.4.0)#7
Merged
Conversation
Mirrors @validpay/node-sdk 0.7.0. Integrators who seal a file get back a retrieval_id + key but were on their own to render the verify QR and guess where to put it on the document — fiddly, since PDFs use a bottom-left origin while every screen uses top-left. Adds validpay.pdf: - embed_qr(pdf_bytes, retrieval_id, key, placement) -> sealed PDF bytes. - QrPlacement contract: anchor (page corner) + x/y insets + width + units + page. The EXACT vocabulary the Node SDK and the website "Try it" tool use, so a position picked once maps 1:1. - build_verify_url + resolve_qr_rect: pure, dependency-free helpers. - Scannability guard: warns under ~72pt, raises if off-page. New optional extra `validpay[pdf]` (qrcode, Pillow, reportlab, pypdf), lazily imported — the core SDK stays dependency-light. 19 new tests. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors @validpay/node-sdk 0.7.0. Adds embed_qr(pdf_bytes, retrieval_id, key, placement) + QrPlacement contract (anchor + insets + width + units + page) + pure build_verify_url / resolve_qr_rect helpers. New optional extra validpay[pdf] (qrcode, Pillow, reportlab, pypdf), lazily imported — core stays dependency-light. 19 new tests; full suite green.