fix(097-C1): commitment hash over ciphertext, version-gated verify#4
Merged
Conversation
compute_commitment_hash now hashes the ciphertext blob, not the plaintext (C-1). create_intent / create_split_key_intent / create_selective_intent hash encrypted_payload after encryption. Verification recomputes SHA-256(ciphertext) and compares ONLY when the API reports commitment_version >= 2; legacy v1 (plaintext-hash) intents skip the check (confirmation-oracle risk) and still verify. Selective-disclosure integrity is now role-independent (the envelope hash needs no plaintext). Tests updated. Co-authored-by: Mike <mtn.mh1.inv@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
ValidPay-io
force-pushed
the
fix/commitment-hash-ciphertext
branch
from
June 15, 2026 00:52
3cfe23f to
51f622b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prompt 097 — Fix 1 (C-1). Python SDK half of the commitment-hash fix. Pairs with ValidPay-API#95.
compute_commitment_hashnow hashes the ciphertext blob, not the plaintext.create_intent/create_split_key_intent/create_selective_intenthashencrypted_payloadafter encryption.SHA-256(ciphertext)and enforces it only whencommitment_version >= 2; legacy v1 (plaintext-hash) intents skip the check and still verify (confirmation-oracle risk).Publish bump (
1.1.0 → 1.2.0) happens after all 097 PRs land (combined with the AAD change in PR5).🤖 Generated with Claude Code