Repository navigation
[INF-517] Track the ve-ci-manager App private key - #64
Open
jacob-ablowitz wants to merge 2 commits into
Open
jacob-ablowitz wants to merge 2 commits into
jacob-ablowitz wants to merge 2 commits into
Conversation
Add the key to the rotation reminders with an annual cadence, rotation and revoke steps, and the permissions that must not be added. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Code Review
This pull request adds a new credential rotation configuration for the VE_CI_MANAGER_APP_PRIVATE_KEY in .github/credential-rotations.yml. The feedback points out a minor directional error in the rotation steps, where step 6 instructs the user to update the expires field "below", whereas the field is actually defined "above" the rotation_steps block.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
VE_CI_MANAGER_APP_PRIVATE_KEYto.github/credential-rotations.yml. Theve-ci-managerGitHub App gives the CI cluster manager its own API rate limit, and its private key is rotated by hand.Checks
python3 .github/scripts/reminders_validate.pypasses.Review note
Opened ready rather than draft: this is one additive entry in a validated config file.
🤖 Generated with Claude Code