Skip to content

[INF-517] Track the ve-ci-manager App private key - #64

Open
jacob-ablowitz wants to merge 2 commits into
mainfrom
chore/INF-517-ve-ci-manager-key
Open

jacob-ablowitz wants to merge 2 commits into
mainfrom
chore/INF-517-ve-ci-manager-key

Conversation

@jacob-ablowitz

Copy link
Copy Markdown
Member

What

Adds VE_CI_MANAGER_APP_PRIVATE_KEY to .github/credential-rotations.yml. The ve-ci-manager GitHub App gives the CI cluster manager its own API rate limit, and its private key is rotated by hand.

  • App: 5826181, installation 183525254, ve-app only.
  • Permissions: Issues read/write; Actions, Pull requests and Metadata read-only.
  • Cadence: annual, next due 2027-11-18. GitHub App keys don't expire on their own.
  • The entry also covers: rotation and verification steps, how to revoke, the compromise impact, and the permissions that must not be added.

Checks

  • python3 .github/scripts/reminders_validate.py passes.
  • The App's permissions were read back from GitHub's public App API.
  • With the installed key, reads of issues, runs and pull requests worked. Source, secrets, run cancel and workflow dispatch were refused.

Review note

Opened ready rather than draft: this is one additive entry in a validated config file.

🤖 Generated with Claude Code

Add the key to the rotation reminders with an annual cadence, rotation
and revoke steps, and the permissions that must not be added.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found. The new VE_CI_MANAGER_APP_PRIVATE_KEY entry has all required fields, a valid ISO expiry date, and the same structure as the existing entries.

@enterprise-gemini-code-assist enterprise-gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new credential rotation configuration for the VE_CI_MANAGER_APP_PRIVATE_KEY in .github/credential-rotations.yml. The feedback points out a minor directional error in the rotation steps, where step 6 instructs the user to update the expires field "below", whereas the field is actually defined "above" the rotation_steps block.

Comment thread .github/credential-rotations.yml Resolved
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant