feat(editor): unify SerializeReference window design and keyboard nav#150
Merged
Conversation
- rebuild sample rows as glass cards whose whole header line is one flat gradient button (References "Fix all" idiom): title left, verb pinned right, soft accent hover glow - imported samples get a direct error-accent Remove action (confirm dialog + AssetDatabase.DeleteAsset) instead of the old whole-row reimport pill - add an accent underline sweep riding the header divider, triggered from the header button hover via a card modifier class; red on Remove cards - keep the animated title inside the brand green family and drop the hero blurb's opaque plate plus dead standalone-window leftovers (duplicate dots background, :root bg token override, manual hover recolor) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TiKFbkrKkZRZuXKT7f933W
- own titleContent and a MinWindowSize floor in CreateGUI so every window instance gets them, including panes restored from saved layouts that never pass through Reveal - add Documentation / GitHub / Asset Store quick links under the hero blurb, styled after the footer link - mark not-yet-imported samples with a brand-blue dot ahead of the title (unread-marker idiom) that turns import-green while the header verb is hovered; drop the decorative Import chevron - seat the hover sweep exactly on the divider line and dim inactive tab underlines to the card-border tone so the active green owns the hierarchy Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TiKFbkrKkZRZuXKT7f933W
- sample card state dot now covers both states: brand-blue while not imported, green once imported (was: dot only for missing samples) - hover/sweep transitions unified to the shared 0.25s ease-out beat across Welcome and Settings cards Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R82xNiuEFN7fFmDPzpJMfz
…d row divider - assign-picker chrome (focused-search frame, row hover/selection, magnifier and breadcrumb hovers) follows the host card accent via a new card-level --migrate modifier: amber on broken-type cards, info on [MovedFrom] migration cards - picker rows rebuilt as a transparent shell plus a 22px content wrapper painting a shared row_bg variable, because DynamicHeight virtualization ignores item margins and padding; the pinned-block divider is now its own hairline element with 4px air on both sides instead of a border that curved with the row radius - attached picker footer becomes a rounded pill level with the header strip Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R82xNiuEFN7fFmDPzpJMfz
- Arrow keys walk a flat focus ring over every actionable element (Rescan, Fix all headers, Smart Fix / Migrate rows, entry rows); Enter activates, Escape clears; the open type picker keeps the keyboard. - AspidGradientButton gains a Highlighted flag driving its hover visual (accent overlay + label tint) programmatically; mouse hover and the flag compose. - Focused Fix all headers also light their card's divider sweep, so keyboard focus renders identically to mouse hover; plain rows take the hover fill via a --focused class. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Sdu159BPL33aGCGkCUsjZf
Co-Authored-By: Claude <noreply@anthropic.com>
…at/welcome-tab-redesign
- make entry-row path/rid/field labels selectable; row jump skips when the click ends a text selection - add right-click menu on entry rows: Open in Asset References, Open in Prefab Mode, Select in Project (built-in Copy removed) - group Required violations by asset with entry/file counters; split overview header counts across helpers Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
- add keyboard nav ring (arrows/Enter/Esc) over rescan, document headers, node bands, action rows and orphan clears - add band divider + accent hover sweep to node cards; flatten Migrate/Smart Fix gradient pills into accent action rows - split overview headline into per-kind counts, add amber/blue accent legend shown when both tones are on screen - make footer paths/rids selectable with start-elided paths; retint picker chrome via row_bg variable per card accent Co-Authored-By: Claude <noreply@anthropic.com>
- Arrow keys walk a focus ring over the sample header buttons (Enter activates, Escape clears), matching the references tabs - Highlight drives AspidGradientButton.Highlighted plus the card divider sweep; the ring rebuilds after Import/Remove keeping the slot Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…stem - glass section cards with flat scope-striped rows and a keyboard focus ring (↑/↓/Enter/←/→/Del/Esc) over every control - underlined Settings header with description; scope legend moved up from the reset footer; reset row aligned to the left grid - excluded-folders list rebuilt as flat add/remove rows with neutral hover; branded scrollbar and window-footer hints - exclude Assets/DevTests from scans in the dev project's shared settings Co-Authored-By: Claude <noreply@anthropic.com>
- rename both settings tree nodes to Aspid.FastTools; the References section card to SerializeReference - add per-area Preferences child pages (SerializeReference, Type Selector, Welcome) via BuildAreaProviderPage; AddSection accepts a null title for them - append the version footer to every provider page as a surface sibling so its hairline spans edge to edge; AspidWindowFooter gains a keys-hint-less constructor (UxmlElement keeps the public default one) Co-Authored-By: Claude <noreply@anthropic.com>
Add checklist items (EN+RU) for the branch's new behaviors: keyboard navigation across all tabs, audit entry context menu and copyable start-elided paths, header legend with split counts. Update settings surface paths to the new Aspid.FastTools menu structure and fix the stale legend-location note in the settings stylesheet. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L3B4bMTPpd7FUmzJCt2Kfc
VPDPersonal
added
type: feature
… tabs Address a code-review pass over the window keyboard-navigation redesign. Correctness: - Settings nav no longer dies after a reset-button click — the editing-control guard matched Button (which derives from TextElement); it now targets text/slider editing controls specifically. - Collapsed document bands drop their hidden node members out of the ring, so up/down skip them and Enter can't activate an off-screen node. - A mouse pass over a keyboard-focused Welcome card keeps its divider sweep lit (the MouseLeave now guards on nav focus like the two audit tabs). Cleanup: - Extract the ~90-line focus ring into a shared NavRing (Welcome / Asset / Project / Settings) and the header hover-sweep mirror into HoverSweep. - Extract BuildCountText / MakeSelectable / the amber-blue legend into a shared SerializeReferenceAuditUI used by both audit tabs. - Resolve a group's constraint + [MovedFrom] migration once (GroupMigration) instead of 2-3x per render. - Make AspidSettingsUI members internal (internal class must not expose public members). Verified: Unity recompile clean, no errors or warnings. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013koTN9rufYUFQVZxCZs4kV
VPDPersonal
marked this pull request as ready for review
July 23, 2026 20:57
github-actions
Bot
added
status: needs-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preferences → Aspid.FastToolswith SerializeReference / Type Selector / Welcome subpages.Notes for review
SerializeReferenceSharedSettings.assetdiff is a serialized-field touch).mainmid-branch (pipeline tooling update) — its noise is not part of the redesign.🇷🇺 Описание на русском
Summary
Preferences → Aspid.FastToolsс подстраницами SerializeReference / Type Selector / Welcome.Notes for review
SerializeReferenceSharedSettings.asset— сериализованное поле).mainпосреди ветки (обновление pipeline-тулинга) — его шум не относится к редизайну.