feat(serializereferences): add Required-violations audit UI#148
Merged
VPDPersonal merged 4 commits intoJul 21, 2026
Merged
Conversation
- Add a "Required violations" card to Project References, fed by a new SerializeReferenceGateScanner.ScanAssetRequiredFields / GateOptions.RequiredOnly, so unset [TypeSelector(Required = true)] fields are auditable project-wide without a build. - Badge unset required [SerializeReference] slots in Asset References, plus a fallback "Required" card for string/SerializableType required fields that have no graph node. - Cover the new scan paths and the graph/gate path-matching with EditMode tests; add a RequiredViolationsDevTest fixture for manual QA. - Update the QA checklist (EN/RU). Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
…olumn" This reverts commit 1a32c9b.
- Asset References: required string/SerializableType fields get the same empty-slot card as managed references, with an inline "Assign Required" picker that writes the picked type's AQN via the live serialization API - style required cards like Missing (amber <None> header and band accent, REQUIRED badge dropped); overview headline, hint and canvas tone now report "N required fields unassigned" instead of a green all-clear - Project References: align the Required-violations header with group cards and fix "entrys" pluralization Co-Authored-By: Claude <noreply@anthropic.com>
VPDPersonal
marked this pull request as ready for review
July 21, 2026 18:53
VPDPersonal
deleted the
feat/asp-59-show-required-violations-in-project-references
branch
July 21, 2026 18:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SerializeReferenceGateScanner.ScanAssetRequiredFields/GateOptions.RequiredOnly— audits every unset[TypeSelector(Required = true)]field project-wide without a build.[SerializeReference]slots inline, plus a fallback "Required" card forstring/SerializableTyperequired fields the managed-reference graph has no node for.RequiredViolationsDevTestDevTests fixture for manual verification.Notes for review
Requiredviolation on a plainstring/SerializableTypefield has no graph node (noRefIdsentry), so Asset References shows it in a separate flat "Required" card instead of a badge on a graph card.Linked issues
Closes ASP-59
🇷🇺 Описание на русском
Итог
SerializeReferenceGateScanner.ScanAssetRequiredFields/GateOptions.RequiredOnly— аудит всех незаполненных[TypeSelector(Required = true)]-полей по всему проекту без сборки.[SerializeReference]подсвечиваются бейджем прямо на карточке, а дляstring/SerializableTyperequired-полей (у них нет узла графа) добавлена отдельная карточка "Required".RequiredViolationsDevTestдля ручной проверки.На что обратить внимание
string/SerializableType-поле не имеет узла графа (нет записиRefIds), поэтому в Asset References оно показывается отдельной плоской карточкой "Required", а не бейджем на карточке графа.Связанные задачи
Closes ASP-59