Skip to content

[k2] log built-in calls in tests #1550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Shamzik merged 6 commits into from
Mar 13, 2026
Merged

[k2] log built-in calls in tests #1550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2624211
log built-in call
Shamzik Mar 11, 2026
4bdcb7f
log in tests
Shamzik Mar 11, 2026
7852979
ingnore debug and indo logs
Shamzik Mar 11, 2026
fdf5a50
aggregate call logs in each test
Shamzik Mar 11, 2026
a51b7f7
fix RUST_LOG
Shamzik Mar 11, 2026
820bc74
SAVE_BUILTIN_CALL_STATS -> DUMP_BUILTIN_CALL_STATS
Shamzik Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/code-gen/vertex-compiler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -917,7 +917,7 @@ void compile_func_call(VertexAdaptor<op_func_call> root, CodeGenerator &W, func_
}

if (is_function_call_should_be_tracked(func)) {
W << "SAVE_BUILTIN_CALL_STATS(\"" << func->name << "\", (";
W << "DUMP_BUILTIN_CALL_STATS(\"" << func->name << "\", (";
}

if (mode == func_call_mode::fork_call) {
Expand Down
9 changes: 9 additions & 0 deletions runtime-light/stdlib/diagnostics/functions-call-stats.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
// Compiler for PHP (aka KPHP)
// Copyright (c) 2026 LLC «V Kontakte»
// Distributed under the GPL v3 License, see LICENSE.notice.txt

#pragma once

#include "runtime-light/stdlib/diagnostics/logs.h"

#define DUMP_BUILTIN_CALL_STATS(builtin_name, builtin_call) (kphp::log::debug("built-in called: " builtin_name), builtin_call)
2 changes: 1 addition & 1 deletion runtime/runtime-builtin-stats.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,6 @@ inline void save_virtual_builtin_call_stats(const kphp::stl::string<kphp::memory
}
} // namespace runtime_builtins_stats

#define SAVE_BUILTIN_CALL_STATS(builtin_name, builtin_call) \
#define DUMP_BUILTIN_CALL_STATS(builtin_name, builtin_call) \
(!runtime_builtins_stats::request_stats.has_value() ? 0 : (*runtime_builtins_stats::request_stats).builtin_stats[std::string_view(builtin_name)]++, \
builtin_call)
1 change: 1 addition & 0 deletions tests/kphp_tester.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ def set_up_env_for_k2(self):
self.env_vars["KPHP_ENABLE_GLOBAL_VARS_MEMORY_STATS"] = "0"
self.env_vars["KPHP_PROFILER"] = "0"
self.env_vars["KPHP_FORCE_LINK_RUNTIME"] = "1"
self.env_vars["KPHP_TRACKED_BUILTINS_LIST"] = KphpRunOnce.K2_KPHP_TRACKED_BUILTINS_LIST


def make_test_file(file_path, test_tmp_dir, test_tags):
Expand Down
Loading
Loading