Skip to content

[k2] change support logging level in error_reporting #1549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
denisichh merged 2 commits into from
Mar 11, 2026
Merged

[k2] change support logging level in error_reporting #1549

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
489e441
supported level for php log level has been changed
denisichh Mar 10, 2026
1f91730
added comment
denisichh Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 4 additions & 18 deletions runtime-light/stdlib/diagnostics/error-handling-functions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,27 +103,13 @@ inline int64_t f$error_reporting(Optional<int64_t> new_error_level_opt = {}) noe
return current_error_level;
}

int64_t new_error_level{new_error_level_opt.val()};
if (new_error_level != 0 && (new_error_level & ErrorHandlingState::SUPPORTED_ERROR_LEVELS) == 0) {
// ignore error_level if it's unsupported
return current_error_level;
}
error_handling_st.minimum_log_level = 0;
if (new_error_level == 0) {
return current_error_level;
} else if ((new_error_level & E_ALL) == E_ALL) {
error_handling_st.minimum_log_level |= static_cast<int64_t>(E_ALL);
if (int64_t new_error_level{new_error_level_opt.val()}; new_error_level == 0) {
return current_error_level;
}

if ((new_error_level & E_NOTICE) == E_NOTICE) {
error_handling_st.minimum_log_level |= static_cast<int64_t>(E_NOTICE);
}
if ((new_error_level & E_WARNING) == E_WARNING) {
error_handling_st.minimum_log_level |= static_cast<int64_t>(E_WARNING);
}
if ((new_error_level & E_ERROR) == E_ERROR) {
error_handling_st.minimum_log_level |= static_cast<int64_t>(E_ERROR);
}
// currently only minimum_log_level == 0 and minimum_log_level == E_ALL are supported,
// because behavior in the runtime/ and runtime-light/ is different. we will fix this in the future.
error_handling_st.minimum_log_level = static_cast<int64_t>(E_ALL);
return current_error_level;
}
Loading