Handle iOS app launch failures after install#414
Open
mdub1na wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
idb installoutput before launching an iOS appProblem
After an iOS IPA was installed successfully, the install plugin attempted to auto-launch the app. The bundle id was parsed with a broad regular expression that could match the status word from
idb installoutput instead of the actual bundle id.For example, with install output like:
the old parser could try to launch
Installedinstead ofcom.testing.app, leading to an error like:The same flow also sent fractional progress values, producing noisy warnings such as:
Fix
Parse the bundle id explicitly from
Installed: <bundleId>/Installed <bundleId>output, skip the launch if the bundle id cannot be detected, and catch launch failures so a failed post-install launch does not become an unhandled rejection. Progress updates are rounded before being sent.Testing
npm run build