Skip APK manifest lookup for iOS installs#413
Open
mdub1na wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/manifestfor iOS.ipauploads stored as/s/blob/...Problem
The application install UI reused the Android APK manifest lookup for every uploaded file once an
hrefexisted. This works for Android APK uploads because manifests are exposed under/s/apk/:id/:name/manifest, but iOS IPA uploads are stored as generic blobs under/s/blob/:id/:nameand do not have a manifest endpoint.This caused the UI to issue a failing request during iOS installs, for example:
Fix
Gate the manifest query with
this.isAndroid, so the query is enabled only when installing Android applications. iOS installs continue to pass the uploaded blob href directly to the device install flow.Testing
npm run type-checkinginuicurrently fails on pre-existing errors unrelated to this change (exponential-backoffmodule resolution and nullable promise typing in socket/device-screen code).