feat: add render prop#9918
Open
SevereCloud wants to merge 1 commit into
Open
Conversation
Contributor
size-limit report 📦
|
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9918 +/- ##
=======================================
Coverage 95.22% 95.22%
=======================================
Files 462 462
Lines 12516 12522 +6
Branches 4477 4478 +1
=======================================
+ Hits 11918 11924 +6
Misses 598 598
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
👀 Docs deployed
📦 Package ✅yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9918/a8cac1d6badb9809920309b20d176cf355a0d4a6/pkg/@vkontakte/vkui/_pkg.tgzCommit a8cac1d |
SevereCloud
force-pushed
the
SevereCloud/feat/add-render-prop
branch
from
994ae8b to
a8cac1d
Compare
Contributor
e2e tests |
| }; | ||
|
|
||
| if (render) { | ||
| return <RenderRootComponent render={render} getRootRef={getRootRef} {...resolvedProps} />; |
Contributor
There was a problem hiding this comment.
А точно нужно дополнительный узел в дереве создавать? Нельзя просто?
if (render) return render({ ...resolvedProps, getRootRef });
Contributor
Author
There was a problem hiding this comment.
Нельзя, так как ругается компилятор
3 tasks
vkcom-publisher
added
the
pr-needs-work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
e2e-тестыДизайн-ревьюОписание
Добавляем свойство render для компонентов
Release notes
Улучшения
renderна заменуComponent