Skip to content

feat: create table components#6615

Draft
inomdzhon wants to merge 2 commits into
masterfrom
imirdzhamolov/research/Table-cmp
Draft

feat: create table components#6615
inomdzhon wants to merge 2 commits into
masterfrom
imirdzhamolov/research/Table-cmp

Conversation

@inomdzhon

@inomdzhon inomdzhon commented Feb 22, 2024

Copy link
Copy Markdown
Contributor

  • Unit-тесты
  • e2e-тесты
  • Дизайн-ревью
  • Документация фичи

Описание

Базовая версия таблиц, которая работает только как ячейки куда можно вставлять свои компоненты.

Стилизуются:

  • разделитель;
  • фон;
  • цвет шрифта в theader/tfooter.

@github-actions

github-actions Bot commented Feb 22, 2024

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
JS 361.58 KB (+1.1% 🔺)
JS (gzip) 110.33 KB (+1.15% 🔺)
JS (brotli) 91.14 KB (+1.09% 🔺)
JS import Div (tree shaking) 1.43 KB (0%)
CSS 264.46 KB (+0.98% 🔺)
CSS (gzip) 34.8 KB (+1.24% 🔺)
CSS (brotli) 28.22 KB (+1.23% 🔺)

@codesandbox-ci

codesandbox-ci Bot commented Feb 22, 2024

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions

github-actions Bot commented Feb 22, 2024

Copy link
Copy Markdown
Contributor

e2e tests

Playwright Report

@codecov

codecov Bot commented Feb 22, 2024

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.88889% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.48%. Comparing base (6b8e5c3) to head (2130b1e).
⚠️ Report is 2462 commits behind head on master.

Files with missing lines Patch % Lines
...ckages/vkui/src/components/TableCell/TableCell.tsx 87.80% 5 Missing ⚠️
...c/components/TableHeaderLabel/TableHeaderLabel.tsx 78.57% 3 Missing ⚠️
packages/vkui/src/lib/utils.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6615      +/-   ##
==========================================
+ Coverage   82.43%   82.48%   +0.05%     
==========================================
  Files         339      348       +9     
  Lines       10395    10485      +90     
  Branches     3475     3500      +25     
==========================================
+ Hits         8569     8649      +80     
- Misses       1826     1836      +10     
Flag Coverage Δ
unittests 82.48% <88.88%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Feb 22, 2024

Copy link
Copy Markdown
Contributor

👀 Docs deployed

Commit 2130b1e

@github-actions github-actions Bot added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Mar 1, 2024
Comment thread packages/vkui/src/components/TableCell/TableCell.module.css Outdated
@github-actions github-actions Bot removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Mar 2, 2024
@github-actions github-actions Bot added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Mar 10, 2024
@inomdzhon inomdzhon force-pushed the imirdzhamolov/research/Table-cmp branch from 4653c78 to 7c52f05 Compare March 15, 2024 14:38
@vkcom-publisher vkcom-publisher removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Mar 16, 2024
@inomdzhon inomdzhon added the no-stale Добавляет PR в исключения для автоматического закрытия label Mar 20, 2024
@inomdzhon inomdzhon force-pushed the imirdzhamolov/research/Table-cmp branch from 7c52f05 to 2130b1e Compare April 5, 2024 15:00
@dsedinkin

Copy link
Copy Markdown

Интересно когда релиз планируется)

@inomdzhon

Copy link
Copy Markdown
Contributor Author

Интересно когда релиз планируется)

У дизайна задача пока в бэклоге, возможно осенью возьмут в работу

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-stale Добавляет PR в исключения для автоматического закрытия

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Draft][Feature]: компоненты таблиц

4 participants