Skip to content

Restructure ndi.cloud.api.documents#4

Merged
stevevanhooser merged 1 commit intomainfrom
ndi-cloud-api-documents-structure-10462111104353685010
Feb 6, 2026
Merged

Restructure ndi.cloud.api.documents#4
stevevanhooser merged 1 commit intomainfrom
ndi-cloud-api-documents-structure-10462111104353685010

Conversation

@google-labs-jules
Copy link
Contributor

This PR addresses the user request to restructure ndi.cloud.api.documents into a proper nested package structure and implement the missing document operations.

Changes:

  • Added __init__.py to src/ndi/cloud/api/implementation.
  • Added implementation classes for document operations in src/ndi/cloud/api/implementation/documents/.
  • Created src/ndi/cloud/api/documents.py which wraps the implementation classes and exposes user-friendly functions.
  • Verified the structure allows import ndi.cloud.api.documents.
  • Added unit tests to verify the new functionality.

PR created automatically by Jules for task 10462111104353685010 started by @stevevanhooser

- Created `src/ndi/cloud/api/implementation/__init__.py` to make it a package.
- Created `src/ndi/cloud/api/implementation/documents/` directory and `__init__.py`.
- Implemented document operations (`add_document`, `get_document`, `update_document`, `delete_document`, `list_dataset_documents`) in `src/ndi/cloud/api/implementation/documents/`.
- Created `src/ndi/cloud/api/documents.py` as a module exposing these operations.
- Added unit tests in `tests/test_cloud_documents.py`.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@stevevanhooser stevevanhooser merged commit 2eb8b74 into main Feb 6, 2026
2 checks passed
@stevevanhooser stevevanhooser deleted the ndi-cloud-api-documents-structure-10462111104353685010 branch February 6, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant