Skip to content

Conversation

@google-labs-jules
Copy link
Contributor

Refactored the test directory structure to mirror the src/ndi package structure, moving tests into tests/nditests/unittest/. This improves organization and maintainability. Updated README.md to specify the correct unittest command (python -m unittest discover -s tests -t .). Crucially, tests/ndi was renamed to tests/nditests to introduce a unique package name between tests and unittest, preventing the test directory from shadowing the installed ndi library during testing.


PR created automatically by Jules for task 1426338253063092469 started by @stevevanhooser

- Moved tests to `tests/nditests/unittest/...`
- Renamed test files to match module names.
- Updated README.md with correct test execution command.
- Renamed `tests/ndi` to `tests/nditests` to prevent namespace shadowing.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

google-labs-jules bot and others added 2 commits February 7, 2026 15:15
- Created `tests/nditests/unittest/ndimatlabport/` structure.
- Added `README.md` with comparison table for tracking ported tests.
- Implemented `test_dataset_build.py` mimicking `ndi.unittest.dataset.testDatasetBuild`.
- Implemented `test_session_build.py` mimicking `ndi.unittest.session.testSessionBuild`.
@stevevanhooser stevevanhooser merged commit 72c974f into main Feb 7, 2026
2 checks passed
@stevevanhooser stevevanhooser deleted the refactor-tests-structure-1426338253063092469 branch February 7, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant