Fix packaging: include did.implementations subpackage #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
pip install(non-editable) omits thedid.implementationssubpackage becausepyproject.tomlhardcodespackages = ["did"]ModuleNotFoundError: No module named 'did.implementations'when importingdid.implementations.sqlitedbpip install -e .(editable mode) exposes the full source tree via a.pthfileRoot cause
PR #12 refactored from
setup.py(which usedfind_packages()— auto-discovers all subpackages) topyproject.tomlwith a hardcoded package list that only includes["did"], missingdid.implementations.Fix
Replace the hardcoded list with setuptools auto-discovery:
This matches the original
setup.pybehavior and will automatically include any future subpackages.Verification
Tested with a clean non-editable install:
Before the fix, this produces
ModuleNotFoundError.Note
The MATLAB version (DID-matlab) doesn't have this issue because
genpath()recursively adds all subdirectories. This fix brings the Python packaging in line with that behavior.🤖 Generated with Claude Code