Skip to content

upipe_ts_scte35_decoder: fix use-after-unmap in command handlers #1168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kierank wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Open

upipe_ts_scte35_decoder: fix use-after-unmap in command handlers #1168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/upipe-ts/upipe_ts_scte35_decoder.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,8 +196,8 @@ static void upipe_ts_scte35d_insert_command(struct upipe *upipe,
upipe_ts_scte35d_parse_descs(upipe, uref, scte35_get_descl(scte35),
scte35_get_desclength(scte35));

uref_block_unmap(uref, 0);
uref_ts_scte35_set_message(uref, scte35, size);
uref_block_unmap(uref, 0);
ubuf_free(uref_detach_ubuf(uref));

uref_ts_scte35_set_command_type(uref, SCTE35_INSERT_COMMAND);
Expand Down Expand Up @@ -284,8 +284,8 @@ static void upipe_ts_scte35d_time_signal_command(struct upipe *upipe,
if (descl)
upipe_ts_scte35d_parse_descs(upipe, uref, descl, desc_length);

uref_block_unmap(uref, 0);
uref_ts_scte35_set_message(uref, scte35, size);
uref_block_unmap(uref, 0);
ubuf_free(uref_detach_ubuf(uref));

upipe_ts_scte35d_output(upipe, uref, upump_p);
Expand Down Expand Up @@ -326,8 +326,8 @@ static void upipe_ts_scte35d_null_command(struct upipe *upipe,
upipe_ts_scte35d_parse_descs(upipe, uref, scte35_get_descl(scte35),
scte35_get_desclength(scte35));

uref_block_unmap(uref, 0);
uref_ts_scte35_set_message(uref, scte35, size);
uref_block_unmap(uref, 0);
ubuf_free(uref_detach_ubuf(uref));

uref_ts_scte35_set_command_type(uref, SCTE35_NULL_COMMAND);
Expand Down
Loading