Conversation
Included discussion of EAFP coding style
Corrected the formatting of the EAFP link in the text.
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/UoMResearchIT/programming_with_python/compare/md-outputs..md-outputs-PR-56 The following changes were observed in the rendered markdown documents: What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2026-04-13 11:39:47 +0000 |
andrewgait
left a comment
There was a problem hiding this comment.
I agree that the sign test is likely better in this instance (and if they've done the introductory python course, there's something similar in that), so I would change it to use that test instead.
andrewgait
left a comment
There was a problem hiding this comment.
Looks good to me now - approved to merge.
Auto-generated via `{sandpaper}`
Source : c8f007d
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2026-04-13 12:48:25 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 312e3c3
Branch : main
Author : scottan <33283688+Scottan@users.noreply.github.com>
Time : 2026-04-13 12:47:22 +0000
Message : Merge pull request #56 from UoMResearchIT/21-make-errors-example-into-a-function
21 make errors example into a function
I've made it into a function and updated some of the text
Any thoughts on replacing:
with:
I personally think it's a clearer and less distracting test, see #21.
I also wonder if we should add a note saying it is usually a good idea to put the try / except statements inside the function, but we are going to leave them outside the function for these examples