fix: unnests the user id in the regex suite#113
Merged
Conversation
…lid and a lot of SDKs do not like it
sighphyre
commented
Feb 25, 2026
| } | ||
| ] | ||
| }, | ||
| { |
Member
Author
There was a problem hiding this comment.
Tests for this project assert that top level props can't be explicitly null so we work around that by offloading it to a property
krzychukula
reviewed
Feb 25, 2026
krzychukula
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't actually a valid context structure. Top level properties belong in the top layer. This is tolerated in the Node SDK because JavaScript reasons . It's tolerated in Yggdasil because Edge (backed by Yggdasil) needs to match the frontend API (backed by the Node SDK). Sooo... also because JavaScript reasons
This unnests that structure so literally every single other SDK we have can actually use this