Skip to content

fix(signatures): cover ucp-agent and signature-agent when signing #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sakinaroufid wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(signatures): cover ucp-agent and signature-agent when signing #785

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions docs/specification/signatures.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,8 @@ verification.
**Signature Generation:**

```text
sign_rest_request(method, path, query, body_bytes, idempotency_key, private_key, kid):
sign_rest_request(method, path, query, body_bytes, ucp_agent, signature_agent,
idempotency_key, private_key, kid):
// 1. Compute body digest (if body present)
if body_bytes:
digest = sha256(body_bytes) // Hash raw bytes, no canonicalization
Expand All @@ -459,9 +460,11 @@ sign_rest_request(method, path, query, body_bytes, idempotency_key, private_key,
// 2. Build component list
components = ["@method", "@authority", "@path"]
if query: components.append("@query")
// WBA-shape: bind the key source, tagged with the signature label
if signature_agent: components.append("signature-agent;key=\"sig1\"")
if ucp_agent: components.append("ucp-agent")
if idempotency_key: components.append("idempotency-key")
if body: components.extend(["content-digest", "content-type"])
if body_bytes: components.extend(["content-digest", "content-type"])

// 3. Build signature base (RFC 9421)
signature_base = build_signature_base(
Expand All @@ -470,6 +473,8 @@ sign_rest_request(method, path, query, body_bytes, idempotency_key, private_key,
path=path,
query=query,
headers={
"ucp-agent": ucp_agent,
"signature-agent": signature_agent,
"idempotency-key": idempotency_key,
"content-digest": digest_header,
"content-type": "application/json"
Expand Down
Loading