fix(rest/python): align sample server with ucp-sdk v0.5.0 model and schema updates - #232
Open
segiodongo wants to merge 2 commits into
Open
Conversation
…chema updates Update models and imports for common schemas (Payment, Total, PostalAddress). Ensure fulfillment destinations are converted to FulfillmentDestination with proper discriminator types. Ensure optional address attributes on FulfillmentDestination extra fields are accessed safely via getattr. Initialize checkout totals with required subtotal and total entries to satisfy model validation. Enforce negative discount amounts in totals per protocol schema specification. Update server integration tests to match latest SDK types and pass cleanly.
damaz91
added
the
status:needs-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR updates the Python REST sample server to maintain compatibility with
ucp-sdkv0.5.0 and the latest UCP protocol specifications:Common Schema Import Paths:
Payment,Total,PostalAddress,PaymentCreateRequest) with fallback toucp_sdk.models.schemas.common.types.Fulfillment Destinations Model Alignment:
FulfillmentDestinationinstances with explicittype: "shipping_address"discriminators.FulfillmentDestinationusinggetattrto support extra/dynamic schema fields without raising attribute errors.Checkout Totals Constraints:
subtotalandtotalentries to satisfy Pydantic schema validation before totals calculation.-discount_amount) per schema numeric bounds (amount < 0).Integration Tests: