test: make merchant assertions configuration-agnostic - #106
Open
FanouZeng-TT wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
test_idempotency_createuses"EUR"as its conflict currency:For a merchant whose fixture currency is already EUR, that produces the same
request body under the same idempotency key. A conforming server replays the
original response, while the test expects
409for a conflict.test_fulfillment_flowalso derives its expected checkout total from only theitem price and selected shipping option. This disagrees with the suite's own
checkout verification invariant, which sums every non-
totalentry; a merchantthat adds tax or fees therefore fails an otherwise valid checkout.
Fix: choose a conflict currency distinct from the fixture currency, and
calculate the fulfillment expectation from the complete non-
totalbreakdown.This keeps the USD reference fixture unchanged while allowing other supported
merchant configurations.
Category (Required)
ucp-schematool (resolver, linter, validator). (Requires Maintainer approval)Related Issues
Fixes #103
Checklist
!for breaking changes).Screenshots / Logs (if applicable)
N/A — test-only assertion correction.
🤖 Generated with Claude Code