feat(ur-sdk): PAY_PORTION_FULL_PRECISION support by zi-yang-uni · Pull Request #528 · Uniswap/sdks

zi-yang-uni · 2026-03-02T18:47:19Z

PR Scope

Please title your PR according to the following types and scopes following conventional commits:

fix(SDK name): will trigger a patch version
chore(<type>): will not trigger any release and should be used for internal repo changes
<type>(public): will trigger a patch version for non-code changes (e.g. README changes)
feat(SDK name): will trigger a minor version
feat(breaking): will trigger a major version for a breaking change

Description

[Summary of the change, motivation, and context]

How Has This Been Tested?

[e.g. Manually, E2E tests, unit tests, Storybook]

Are there any breaking changes?

[e.g. Type definitions, API definitions]

If there are breaking changes, please ensure you bump the major version Bump the major version (by using the title feat(breaking): ...), post a notice in #eng-sdks, and explicitly notify all Uniswap Labs consumers of the SDK.

(Optional) Feedback Focus

[Specific parts of this PR you'd like feedback on, or that reviewers should pay closer attention to]

(Optional) Follow Ups

[Things that weren't addressed in this PR, ways you plan to build on this work, or other ways this work could be extended]

✨ Claude-Generated Content

Summary

Add PAY_PORTION_FULL_PRECISION command (0x07) support for higher precision fee calculations using 1e18 scale instead of basis points (1e4)
Conditionally enabled for Universal Router V2.1.1+ to maintain backward compatibility

Changes

`sdks/universal-router-sdk/src/utils/routerCommands.ts`

Added PAY_PORTION_FULL_PRECISION command type (0x07) with portion parameter (1e18 scale)

`sdks/universal-router-sdk/src/utils/numbers.ts`

Added encodeFee1e18() function to encode fees with 18 decimal precision

`sdks/universal-router-sdk/src/entities/actions/uniswap.ts`

Updated UniswapTrade.encode() to use PAY_PORTION_FULL_PRECISION when urVersion >= V2_1_1
Falls back to PAY_PORTION (bips) for older router versions
Updated minimum amount out calculation to use 1e18 division for exact output trades when using full precision

`sdks/universal-router-sdk/test/utils/commandParser.test.ts`

Added unit test for PAY_PORTION_FULL_PRECISION command parsing

`sdks/universal-router-sdk/test/utils/feeEncoding.test.ts` (new)

Added comprehensive tests for encodeFeeBips() and encodeFee1e18() functions
Added tests comparing precision between bips and 1e18 encoding
Added tests verifying correct command bytes (0x06 vs 0x07)

Are there any breaking changes?

No — the external API (options.fee) remains unchanged. The new command is only used when urVersion >= V2_1_1, maintaining backward compatibility with older router versions.

github-actions · 2026-03-20T03:01:55Z

🤖 Claude Code Review

✅ Review complete

Summary

This PR adds support for PAY_PORTION_FULL_PRECISION (command 0x07) in Universal Router v2.1.1, enabling 1e18 precision for fee percentages instead of the legacy bips (1e4) precision.

Changes Reviewed

Core Logic (uniswap.ts:264-311):

Correctly branches based on urVersion >= V2_1_1 to select between PAY_PORTION_FULL_PRECISION and PAY_PORTION
Throws an error for fractional bips fees on older UR versions (line 277-278), preventing silent precision loss
Unified feeDeduction handling - now computed once and applied after both fee conditionals
Passes urVersion to addCommand for the new command (line 287)

Fee Encoding (numbers.ts:20-24):

FULL_PORTION_PRECISION constant correctly represents 1e18
encodeFee1e18() properly multiplies the fee percentage by 1e18

Command Definitions (routerCommands.ts:18, 208-215):

PAY_PORTION_FULL_PRECISION = 0x07 correctly defined
Command definition uses portion parameter name (vs bips for PAY_PORTION)

Tests (feeEncoding.test.ts):

Comprehensive coverage of encoding functions
Tests for command selection based on UR version (undefined, V2_0, V2_1_1)
Tests for exact input/output behavior with both precision levels
Tests verify correct command bytes (0x06 vs 0x07)

Verification of Existing Comments

All previously raised concerns have been addressed:

✅ Version check handles V2_0 consumers correctly (uses PAY_PORTION)
✅ Fractional bips rejection implemented (line 277-278)
✅ feeDeduction unified - no longer duplicated
✅ urVersion passed to addCommand (line 287)
✅ Constant renamed to FULL_PORTION_PRECISION
✅ Tests cover the encode function's fee command selection

No Issues Found

The implementation is correct and handles backward compatibility properly. V2_0 consumers will continue to receive PAY_PORTION with bips encoding, while V2_1_1+ consumers get the new high-precision command.

_{💡 Want a fresh review? Add a comment containing @request-claude-review to trigger a new review at any time.}

github-actions

📋 Review verdict: APPROVE

👆 The main review comment above is the source of truth for this PR review. It is automatically updated on each review cycle, so always refer to it for the most current feedback.

This formal review submission is for the verdict only.

graphite-app · 2026-03-20T03:05:15Z

Graphite Automations

"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (03/20/26)

3 reviewers were added and 1 assignee was added to this PR based on Siyu Jiang (See-You John)'s automation.

kristiehuang · 2026-03-20T15:29:12Z

feat(release): changesets for UR v2.1.1 releases #560
feat(ur-sdk): PAY_PORTION_FULL_PRECISION support #528 👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

kristiehuang

some comments/questions

kristiehuang · 2026-03-20T16:22:25Z

+        TradeType.EXACT_INPUT
+      )
+      const feeOptions: FeeOptions = { fee: new Percent(5, 100), recipient: TEST_FEE_RECIPIENT_ADDRESS }
+      const opts = swapOptions({ fee: feeOptions, urVersion: URVersion.V2_1 })


this will fail to compile -- deprecated 2.1 entirely, this enum value doesn't exist. only 2.0 and 2.1.1

actually wait how did it pass typecheck lol

Superseded by new review after PR update

github-actions

📋 Review verdict: APPROVE

👆 The main review comment above is the source of truth for this PR review. It is automatically updated on each review cycle, so always refer to it for the most current feedback.

This formal review submission is for the verdict only.

github-actions

📋 Review verdict: APPROVE

👆 The main review comment above is the source of truth for this PR review. It is automatically updated on each review cycle, so always refer to it for the most current feedback.

This formal review submission is for the verdict only.

re-approve as swap-be

kristiehuang reviewed Mar 5, 2026

View reviewed changes

Comment thread sdks/universal-router-sdk/src/entities/actions/uniswap.ts Outdated

kristiehuang reviewed Mar 5, 2026

View reviewed changes

Comment thread sdks/universal-router-sdk/src/utils/numbers.ts Outdated

zi-yang-uni requested a review from kristiehuang March 6, 2026 17:25

hensha256 reviewed Mar 13, 2026

View reviewed changes

Comment thread sdks/universal-router-sdk/src/entities/actions/uniswap.ts Outdated

Comment thread sdks/universal-router-sdk/test/utils/feeEncoding.test.ts

zi-yang-uni force-pushed the ziyiyang/portion-precision branch from 269c7cc to 42a18c5 Compare March 13, 2026 16:42

zi-yang-uni requested a review from hensha256 March 13, 2026 16:48

zi-yang-uni added 5 commits March 19, 2026 22:53

feat(ur-sdk): PAY_PORTION_FULL_PRECISION support

2bac023

rename

b9d0ec4

tests

648c7b6

lint

c90818d

address comments

f5ae63a

zi-yang-uni force-pushed the ziyiyang/portion-precision branch from 42a18c5 to f5ae63a Compare March 20, 2026 02:53

zi-yang-uni marked this pull request as ready for review March 20, 2026 03:01

zi-yang-uni requested a review from a team as a code owner March 20, 2026 03:01

graphite-app Bot requested review from a team March 20, 2026 03:02

graphite-app Bot assigned zi-yang-uni Mar 20, 2026

github-actions Bot previously approved these changes Mar 20, 2026

View reviewed changes

kristiehuang mentioned this pull request Mar 20, 2026

feat(release): changesets for UR v2.1.1 releases #560

Merged

kristiehuang reviewed Mar 20, 2026

View reviewed changes

Comment thread sdks/universal-router-sdk/src/entities/actions/uniswap.ts

kristiehuang reviewed Mar 20, 2026

View reviewed changes

Comment thread sdks/universal-router-sdk/src/utils/routerCommands.ts

kristiehuang reviewed Mar 20, 2026

View reviewed changes

Comment thread sdks/universal-router-sdk/src/entities/actions/uniswap.ts Outdated

kristiehuang reviewed Mar 20, 2026

View reviewed changes

kristiehuang requested changes Mar 20, 2026

View reviewed changes

zi-yang-uni added 2 commits March 23, 2026 09:15

comments

fe7ff1c

remove unneeded test case

53eb694

zi-yang-uni requested a review from kristiehuang March 23, 2026 16:17

github-actions Bot approved these changes Mar 23, 2026

View reviewed changes

lint

b6e471e

github-actions Bot approved these changes Mar 23, 2026

View reviewed changes

kristiehuang approved these changes Mar 23, 2026

View reviewed changes

kristiehuang previously approved these changes Mar 23, 2026

View reviewed changes

kristiehuang approved these changes Mar 23, 2026

View reviewed changes

zi-yang-uni merged commit db54625 into main Mar 23, 2026
9 checks passed

zi-yang-uni deleted the ziyiyang/portion-precision branch March 23, 2026 18:18

Dargon789 pushed a commit to Dargon789/sdks that referenced this pull request Apr 17, 2026

feat(ur-sdk): PAY_PORTION_FULL_PRECISION support (Uniswap#528)

7a07984

Conversation

zi-yang-uni commented Mar 2, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Scope

Description

How Has This Been Tested?

Are there any breaking changes?

(Optional) Feedback Focus

(Optional) Follow Ups

✨ Claude-Generated Content

Summary

Changes

sdks/universal-router-sdk/src/utils/routerCommands.ts

sdks/universal-router-sdk/src/utils/numbers.ts

sdks/universal-router-sdk/src/entities/actions/uniswap.ts

sdks/universal-router-sdk/test/utils/commandParser.test.ts

sdks/universal-router-sdk/test/utils/feeEncoding.test.ts (new)

Are there any breaking changes?

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 Claude Code Review

Summary

Changes Reviewed

Verification of Existing Comments

No Issues Found

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

graphite-app Bot commented Mar 20, 2026

Graphite Automations

Uh oh!

kristiehuang commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kristiehuang left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kristiehuang Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kristiehuang Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

zi-yang-uni commented Mar 2, 2026 •

edited by github-actions Bot

Loading

`sdks/universal-router-sdk/src/utils/routerCommands.ts`

`sdks/universal-router-sdk/src/utils/numbers.ts`

`sdks/universal-router-sdk/src/entities/actions/uniswap.ts`

`sdks/universal-router-sdk/test/utils/commandParser.test.ts`

`sdks/universal-router-sdk/test/utils/feeEncoding.test.ts` (new)

github-actions Bot commented Mar 20, 2026 •

edited

Loading

kristiehuang commented Mar 20, 2026 •

edited

Loading

kristiehuang Mar 20, 2026 •

edited

Loading