fix(tracing): preserve existing toolType span attribute#1261
Merged
saksharthakkar merged 5 commits intomainfrom Feb 4, 2026
Merged
fix(tracing): preserve existing toolType span attribute#1261saksharthakkar merged 5 commits intomainfrom
saksharthakkar merged 5 commits intomainfrom
Conversation
50900b8 to
ec8dae7
Compare
The exporter was unconditionally overwriting toolType to "Integration" even when already set by the instrumentor (e.g., "Escalation"). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
ec8dae7 to
84a7083
Compare
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
cristipufu
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
toolTypeto "Integration" even when instrumentor set it to something else (e.g., "Escalation")Test plan
toolType: "Escalation"instead of "Integration"test_tool_span_preserves_existing_tool_type