Skip to content

fix(tracing): preserve existing toolType span attribute#1261

Merged
saksharthakkar merged 5 commits intomainfrom
fix/preserve-toolcall-span-attrs
Feb 4, 2026
Merged

fix(tracing): preserve existing toolType span attribute#1261
saksharthakkar merged 5 commits intomainfrom
fix/preserve-toolcall-span-attrs

Conversation

@saksharthakkar
Copy link
Contributor

@saksharthakkar saksharthakkar commented Feb 4, 2026

Summary

  • Fix exporter overwriting toolType to "Integration" even when instrumentor set it to something else (e.g., "Escalation")
  • Single line change: preserve existing value if set

Test plan

  • Verify escalation tool spans show toolType: "Escalation" instead of "Integration"
  • Unit test added: test_tool_span_preserves_existing_tool_type
image

@github-actions github-actions bot added test:uipath-langchain Triggers tests in the uipath-langchain-python repository test:uipath-llamaindex Triggers tests in the uipath-llamaindex-python repository labels Feb 4, 2026
@saksharthakkar saksharthakkar force-pushed the fix/preserve-toolcall-span-attrs branch from 50900b8 to ec8dae7 Compare February 4, 2026 07:14
The exporter was unconditionally overwriting toolType to "Integration"
even when already set by the instrumentor (e.g., "Escalation").

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@saksharthakkar saksharthakkar force-pushed the fix/preserve-toolcall-span-attrs branch from ec8dae7 to 84a7083 Compare February 4, 2026 07:33
@saksharthakkar saksharthakkar changed the title (wip) fix(tracing): preserve existing toolCall span attributes (wip) fix(tracing): preserve existing toolType span attribute Feb 4, 2026
@saksharthakkar saksharthakkar changed the title (wip) fix(tracing): preserve existing toolType span attribute fix(tracing): preserve existing toolType span attribute Feb 4, 2026
saksharthakkar and others added 3 commits February 3, 2026 23:57
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@saksharthakkar saksharthakkar marked this pull request as ready for review February 4, 2026 08:01
@saksharthakkar saksharthakkar merged commit d4870c1 into main Feb 4, 2026
92 checks passed
@saksharthakkar saksharthakkar deleted the fix/preserve-toolcall-span-attrs branch February 4, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:uipath-langchain Triggers tests in the uipath-langchain-python repository test:uipath-llamaindex Triggers tests in the uipath-llamaindex-python repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants