[ROBO-5186] Fix duplicate stacktraces in logging#122
Open
eduard-dumitru wants to merge 2 commits intomasterfrom
Open
[ROBO-5186] Fix duplicate stacktraces in logging#122eduard-dumitru wants to merge 2 commits intomasterfrom
eduard-dumitru wants to merge 2 commits intomasterfrom
Conversation
bogdanStan92
approved these changes
Dec 10, 2025
| { | ||
| await Stream.WaitForConnectionAsync(); | ||
| } | ||
| catch (ObjectDisposedException) |
Member
There was a problem hiding this comment.
kind of nit: Maybe when (ct.IsCancellationRequested)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix duplicate stacktrace when logging (the
LogErroroverload accepting an exception was being used while the exception was also included in the string message).