Compile all expressions at once when validating.

[aoltean16]

No description provided.

[angelowang]

Hi @aoltean16 , will this change improve the performance? I had to make some change like in #260 to make it much faster on first Run(). There are many duplicated file access which is time consuming when we have a lot of CodeActivities. But even after that, the performance is still 10x slower than the VbHostedCompiler before :(

Seems it's only for design time?

[aoltean16]

Hi @aoltean16 , will this change improve the performance? I had to make some change like in #260 to make it much faster on first Run(). There are many duplicated file access which is time consuming when we have a lot of CodeActivities. But even after that, the performance is still 10x slower than the VbHostedCompiler before :(

Seems it's only for design time?

This improves the validation time drastically, when called by ActivityValidationServices.Validate() with ValidationSettings.ForceExpressionsCache = false, so in theory, yea, only design time will benefit from this

[angelowang]

in theory, yea, only design time will benefit from this

Thanks @aoltean16 . The execution time also needs this eagerly. We have a case where 21 xaml files takes 30s for the first time running. This is still the time after the MetadataReference caching, the original time could be well over several minutes.

The idea might be similar, like each expression's LambdaExpression could be from a separate CreateExpression_actionHash/codeHash/actionId function.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.