[ISSUE-7] Moved all model-specific defaults from Global.h to appropriate model classes#910
Merged
CodersRepo merged 2 commits intoDhruvaDevfrom Feb 12, 2026
Merged
Conversation
stiber
requested changes
Feb 9, 2026
Contributor
stiber
left a comment
stiber
left a comment
There was a problem hiding this comment.
Mostly comments, possibly not requiring change.
stiber
reviewed
Feb 19, 2026
| W_[iEdg] = edgSign(type) * 10.0e-9; | ||
| type_[iEdg] = type; | ||
| tau_[iEdg] = DEFAULT_tau; | ||
| tau_[iEdg] = AllSpikingSynapses::DEFAULT_tau; |
Contributor
There was a problem hiding this comment.
I don't think this needs the scope specification here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…classes
Closes #7
Description
Moved all model-specific defaults from Global.h to appropriate model classes
Checklist (Mandatory for new features)
Testing (Mandatory for all changes)
test-medium-connected.xmlPassedtest-large-long.xmlPassed