Open
Conversation
Rosnaky
requested changes
Apr 1, 2026
| MX_TIM1_Init(); | ||
| /* USER CODE BEGIN 2 */ | ||
| HAL_TIM_PWM_Start(&htim1, TIM_CHANNEL_1); | ||
| pwmCounts = 100 + ((adcValue * 100) / 1023); |
| MX_TIM1_Init(); | ||
| /* USER CODE BEGIN 2 */ | ||
| HAL_TIM_PWM_Start(&htim1, TIM_CHANNEL_1); | ||
| pwmCounts = 100 + ((adcValue * 100) / 1023); |
Member
There was a problem hiding this comment.
The formula to calculate pwmCounts is also not exactly right. You have the right idea, but your period/prescaler values can be more optimized. You want a higher period and a lower prescaler for a higher resolution signal.
| /* USER CODE BEGIN 2 */ | ||
| HAL_TIM_PWM_Start(&htim1, TIM_CHANNEL_1); | ||
| pwmCounts = 100 + ((adcValue * 100) / 1023); | ||
| __HAL_TIM_SET_COMPARE(&htim1, TIM_CHANNEL_1, pwmCounts); |
Member
There was a problem hiding this comment.
This sets the pwm output once. However, if you read a different value from your adc in the while loop, it won't update unless you call this in the while loop.
Comment on lines
+108
to
+110
| txData[0] = 0x01; | ||
| txData[1] = 0x80; | ||
| txData[2] = 0x00; |
Member
There was a problem hiding this comment.
Minor nit- You don't need to call this every time in the while loop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.