Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Isoscelestial
left a comment
Isoscelestial
left a comment
There was a problem hiding this comment.
Looks very good! I think another cool thing would be to add the project logos on each project page. You could use this (and obviously make ClubsLogoStandalone data driven) and replace lines 38-40 in /components/Project.tsx:
<div className="font-display flex gap-2 items-center drop-shadow-sm bg-white rounded-full pl-6 pr-8">
<div className={`flex flex-row items-center`}>
<ClubsLogoStandalone className="h-16 md:h-24 w-auto fill-haiti" />
</div>
<div className="flex flex-col">
<span className="whitespace-nowrap text-xl md:text-2xl font-bold leading-5 text-haiti">
{props.name}
</span>
</div>
</div>
| return ( | ||
| <> | ||
| <Header text="Projects" /> | ||
| <div className="px-8 lg:px-16 xl:px-32 py-24 flex flex-wrap justify-center gap-8"> |
There was a problem hiding this comment.
Zoom out on the page and uhhh you'll see... probably need to put the project links in their own div, then add flex-col to here.
| <Transition {...transitionProps}> | ||
| <DisclosurePanel | ||
| as="ul" | ||
| className="lg:absolute lg:w-full lg:bg-dark-gradient lg:backdrop-blur-md lg:left-0 lg:top-20 lg:mt-6 lg:py-10 lg:px-20 justify-items-center lg:flex-wrap lg:flex lg:gap-10 contents" |
There was a problem hiding this comment.
Something changed and now on certain screen sizes, the project buttons don't take up the full width of the dropdown (so they're left-aligned, which looks strange compared to how it is currently)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wanted a general projects page: https://website-v2-git-projects-page-utdnebula.vercel.app/projects
As a side effect of not being able to use the old project icons without duplicating them in black, this also:
Resolves #123