Skip to content

510 feature request mobile UI add bottom tab bar for mobile only#581

Merged
egsch merged 66 commits intodevelopfrom
510-feature-request-mobile-ui-add-bottom-tab-bar-for-mobile-only
Apr 6, 2026
Merged

510 feature request mobile UI add bottom tab bar for mobile only#581
egsch merged 66 commits intodevelopfrom
510-feature-request-mobile-ui-add-bottom-tab-bar-for-mobile-only

Conversation

@AbhiramTadepalli
Copy link
Copy Markdown
Contributor

@AbhiramTadepalli AbhiramTadepalli commented Mar 1, 2026

Overview

Added a BottomNavBar as per #510 to make mobile navigation easier
Also cleans up nav on the search results page a bit better

What Changed

  • Implements a bottom nav bar on mobile with Search, Compare, and MyPlanner pages
  • Makes Search a tab in the search results page, alongside Course & Professor overviews
  • Creates a new Compare "page" (just a parameter in the url that conditionally renders a diff page)
  • Remove the MyPlanner / Search Results button from the top bar

To-Do's

  • there's a comma at the bottom of the professor overview for some reason now, can you help me find it?
  • Move the report button up
  • style the navbar to look more modern
  • Add a slide transition between tabs (might be hard)
  • Stop the flicker going from compare -> myplanner and myplanner -> compare
  • @TyHil what did you mean by TODO: When PlannerButton is moved to a bottom nav bar, remove the small size props from all the children in this div

@AbhiramTadepalli AbhiramTadepalli linked an issue Mar 1, 2026 that may be closed by this pull request
5 tasks
@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
utd-trends Ready Ready Preview, Comment Apr 6, 2026 4:03am

Request Review

@AbhiramTadepalli
Copy link
Copy Markdown
Contributor Author

AbhiramTadepalli commented Apr 5, 2026

@TyHil @Isoscelestial
Up to 0b51d69: I feel this UI is great cuz it has overscroll, pull to refresh, and in safari (first browser) the url bar shrinks. Downside is in Firefox we get the glassmorphism under the MobileNavBar. Airbnb has the same issue only on firefox so we could just suck it up.

ScreenRecording_04-05-2026.10-26-08_1.1.mp4

Changes I made in 2568771: Remove that issue from the Firefox (2nd browser), but also disable pull to refresh && in Safari the url bar doesn't shrink.

ScreenRecording_04-05-2026.10-28-46_1.mp4

I'm fine to bite the bullet and have Firefox glassmorphism, just let me know and I can revert the last commit

@egsch
Copy link
Copy Markdown
Contributor

egsch commented Apr 5, 2026

I'm fine to bite the bullet and have Firefox glassmorphism, just let me know and I can revert the last commit

I don't think the glassmorphism is a huge issue, especially since firefox + ios is a pretty small proportion of our users

TyHil
TyHil previously requested changes Apr 5, 2026
Copy link
Copy Markdown
Member

@TyHil TyHil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still can't pull to refresh on Android Chrome or Firefox :/

Other than that tho it's looking incredible. And I agree with Emma on the above

Comment thread package-lock.json
…verscrolling the entire `<body/>`"

This reverts commit 2568771.
Copy link
Copy Markdown
Contributor Author

@AbhiramTadepalli AbhiramTadepalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AbhiramTadepalli AbhiramTadepalli dismissed stale reviews from TyHil and Isoscelestial April 6, 2026 04:22

implemented refrsh

Copy link
Copy Markdown
Contributor

@egsch egsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much and sorry for the late merge!

@egsch egsch merged commit a7279e4 into develop Apr 6, 2026
3 checks passed
@egsch egsch deleted the 510-feature-request-mobile-ui-add-bottom-tab-bar-for-mobile-only branch April 6, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Mobile UI: Add bottom tab bar for mobile only

4 participants