Conversation
…gate the available rooms data in mongo
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Also I believe that if merging logic is okay, I could also combine the mergin logic with dedup logic. |
TyHil
left a comment
TyHil
left a comment
There was a problem hiding this comment.
Just 2 things but other than that this looks really good!!
Just to reiterate what you said, we will have to remember to update the Rooms view on the prod db before merging
TyHil
left a comment
TyHil
left a comment
There was a problem hiding this comment.
One thing I noticed with the algorithm is it turns days like this (on JSOM 1.502 Monday 4/13):
into:
Could you add some logic that doesn't merge "all-day" events (12:00am - 11:59pm) with any other events? Or maybe only merges all-day events with other all-day events
Other than that, I think it looks all good!
Ok I'll get on it ASAP, this looks really weird. |
…cluded rooms now that we have much better way of normalizing the room over API
…s' events, which will have duration > 23h. Second, only merge events that overlap at least 15mins, which includes also the situation one event contains another. Any overlapping less than < 15mins, will be kept that way.
|
Alright thanks! Yeah I will update the views for prod first. The rooms from comet calendar have been standardized heavily to match astra and mazevo so there shouldn't be any wildcards (like "We will meet at the bookstore"), but I'll have to see first haha. P.S. I learned a lot from this. |
2 participants
Overview
Resolves #60
Import the comet calendar events data from Nebula API
Because Mazevo and Calendar events share some identical events that have different timeline overlapping each other (differ from 15 minutes to 1 hour), I also create an additional logic to merge those together.
After doing a round of testing, it can actually merge different overlap as well (i.e, overlap between Astra and Mazevo events). The merged events will have "MERGED" at the beginning of the title (just for checking, I could remove this).
If you could provide feedback on the merging, it'd be appreciated since I'm not sure if this is behavior we want to have.
This is tested on the local api with updated Rooms view on the dev MongoDB. So we might have to update Rooms view on prod db.
Note
The merge logic is from the solution to this leetcode problem