Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
TyHil
approved these changes
Mar 26, 2026
Member
TyHil
left a comment
TyHil
left a comment
There was a problem hiding this comment.
This looks good!
One thing would be maybe to rename src/components/sections/HandwrittenFilter.tsx to src/components/sections/Filters.tsx so we can put more filters in it in the future
SinhSinhAn
force-pushed
the
handwritten-notes-filter
branch
from
267dc12 to
e118387
Compare
Contributor
Author
|
Force pushed after rebasing on latest develop , was simpler than resolving merge conflicts from unrelated commits. |
Add handwritten boolean column to file schema and a dropdown filter on the notes page to filter by handwritten, digital, or all notes.
…ypes - Rename HandwrittenFilter.tsx → Filters.tsx for future extensibility - Update dark:bg-neutral-900 → dark:bg-neutral-800 per card color update - Fix filterSections type to use SectionWithFilesWithUserMetadata
SinhSinhAn
force-pushed
the
handwritten-notes-filter
branch
from
e118387 to
bea9e3d
Compare
Contributor
Author
|
Cleaned up the branch , previous push had unrelated commits from search-api and save-notes that leaked in via the merge history. Recreated the branch fresh from develop with only the handwritten filter changes (4 files). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handwrittenboolean column to thefileschema (defaults tofalse), with migrationHandwrittenFilterclient component with MUI Select dropdown (All Notes / Handwritten Only / Digital Only) that updates?handwrittenURL search paramsearchParams, filter files by handwritten state server-side, and render the filter dropdown