Add empty state icon and fix condition (#29)#138
Open
SinhSinhAn wants to merge 1 commit intodevelopfrom
Open
Conversation
- Add FolderOffIcon with optional icon prop to EmptyStateCard - Change empty state condition from sections.length to fileCount so pages with sections but no files show the empty state
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
SinhSinhAn
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EmptyStateCardwith aFolderOffIcondefault and optionaliconprop for customizationfileCount === 0instead ofsections.length === 0, so pages like/CS/2305that have sections but no uploaded files correctly show the empty state