add compile and unit test checks for java 21 and 25#1727
Conversation
currently only running Java 11 integration tests due to target production environments
…th java 11 and java 25
adamkorynta
force-pushed
the
devops/add_java_21_compile_support
branch
from
7375873 to
1d74814
Compare
| // put all those columns together as "valid" | ||
| CommonTableExpression<Record7<BigDecimal, String, String, String, String, BigDecimal, | ||
| String>> valid = | ||
| String>> valid = |
There was a problem hiding this comment.
should probably just use var at this point.
krowvin
left a comment
krowvin
left a comment
There was a problem hiding this comment.
Looks good, few followup thoughts. Thanks for the PR!
| import org.jooq.Cursor; | ||
| import org.jooq.DSLContext; | ||
| import org.jooq.Field; | ||
| import org.jooq.Record; |
There was a problem hiding this comment.
Ah I assume this is also what was keeping java 25 from building?
There was a problem hiding this comment.
yeah pretty simple fix, didn't test integration tests though so there might be more at runtime.
| id: thebuild | ||
| run: ./gradlew clean build --info --init-script init.gradle | ||
| - name: integration tests | ||
| if: matrix.jdk == 11 |
There was a problem hiding this comment.
If i'm reading correct this is saying only do an integration test for 11? Just making sure!
If we have other toggles like this it might be worth using an env in the github repo to have a "JAVA_VERSION" and we can toggle that going forward? Might be extra! Would be good to make an issue for this if someone agrees with the deb hard coding 11 in places gives?
There was a problem hiding this comment.
right now there's some sort of caching issue that's causing the builds to fail so I didn't even try to get 21 or even 25 to run integration tests.
For 25 we would need to update gradle to v9 which drops support for Java 11..... So we could use the gradle toolchain mechanism, which would require downloading a whole separate JRE in the pipeline and referencing that. That could work with a repo level env variable.
There was a problem hiding this comment.
Approving this,
Was not sure if @MikeNeilson had a blocker but realized he would request changes if it was.
And it's listed as draft
3 participants
Summary
Add Java 21 compile/unit test targets to build matrix. currently only running Java 11 integration tests due to target production environments and not wanting to overly abuse GitHub Actions.
Cannot currently add Java 25 support because there is no gradle version that supports both Java 11 and Java 25 unless setting the toolchain version to Java 11 (which defeats the whole purpose).
Related Issue
Related to #1004
Validation
Tested through CI/CD pipeline.
Checklist