Skip to content

CDA-104: Tests for Error when POST timeseries of a Sub Location #1726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zack-rma wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

CDA-104: Tests for Error when POST timeseries of a Sub Location #1726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions cwms-data-api/src/test/java/cwms/cda/api/TimeseriesControllerTestIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import static cwms.cda.api.Controllers.OFFICE;
import static cwms.cda.api.Controllers.OVERRIDE_PROTECTION;
import static cwms.cda.api.Controllers.START_TIME_INCLUSIVE;
import static cwms.cda.api.Controllers.STORE_RULE;
import static cwms.cda.api.Controllers.TRIM;
import static cwms.cda.api.Controllers.UNIT;
import static cwms.cda.api.Controllers.VERSION_DATE;
Expand All @@ -31,6 +32,7 @@
import com.fasterxml.jackson.databind.JsonNode;
import com.fasterxml.jackson.databind.ObjectMapper;
import cwms.cda.ApiServlet;
import cwms.cda.data.dao.StoreRule;
import cwms.cda.data.dao.VerticalDatum;
import cwms.cda.data.dto.TimeSeries;
import cwms.cda.data.dto.VerticalDatumInfo;
Expand Down Expand Up @@ -1029,6 +1031,48 @@ void test_attempt_store_with_entry_date() throws Exception
;
}

@Test
void test_attempt_store_for_nonexistent_subloc() throws Exception
{
ObjectMapper mapper = new ObjectMapper();

InputStream resource = this.getClass().getResourceAsStream(
"/cwms/cda/api/lrl/timeseries_nonexistent_subloc.json");
assertNotNull(resource);

String tsData = IOUtils.toString(resource, StandardCharsets.UTF_8);

JsonNode ts = mapper.readTree(tsData);
String location = ts.get(NAME).asText().split("\\.")[0].split("-")[0];
String officeId = ts.get("office-id").asText();
createLocation(location, true, officeId);

TestAccounts.KeyUser user = TestAccounts.KeyUser.SPK_NORMAL;

// inserting the time series
given()
.log().ifValidationFails(LogDetail.ALL, true)
.accept(Formats.DEFAULT)
.contentType(Formats.JSONV2)
.body(tsData)
.header("Authorization", user.toHeaderValue())
.queryParam(OFFICE, officeId)
.queryParam(CREATE_AS_LRTS, "false")
.queryParam(STORE_RULE, StoreRule.REPLACE_ALL.toString())
.queryParam(OVERRIDE_PROTECTION, "false")
.when()
.redirects().follow(true)
.redirects().max(3)
.post("/timeseries/")
.then()
.log().ifValidationFails(LogDetail.ALL, true)
.assertThat()
.statusCode(is(HttpServletResponse.SC_NOT_FOUND))
.body("message", equalTo("ORA-20025: LOCATION_ID_NOT_FOUND: The Location: \"Buckhorn-Subloc\" does not exist."))
.body("source", equalTo("Database"))
;
}

@Test
void test_delete_ts() throws Exception {
ObjectMapper mapper = new ObjectMapper();
Expand Down
35 changes: 35 additions & 0 deletions cwms-data-api/src/test/resources/cwms/cda/api/lrl/timeseries_nonexistent_subloc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
{
"name": "Buckhorn-Subloc.Temp-Water.Inst.1Day.0.cda-test",
"office-id": "SPK",
"units": "F",
"begin": 1675335600000,
"end": 1675422000000,
"version-date": 1594786000000,
"value-columns" : [
{
"name" : "date-time",
"ordinal" : 1,
"datatype" : "java.sql.Timestamp"
}, {
"name" : "value",
"ordinal" : 2,
"datatype" : "java.lang.Double"
}, {
"name" : "quality-code",
"ordinal" : 3,
"datatype" : "int"
}
],
"values": [
[
1675335600000,
35,
0
],
[
1675422000000,
36,
0
]
]
}
Loading