location catalog text search support#1640
Open
adamkorynta wants to merge 16 commits into
Open
Conversation
demonstrating usage of: HydrologicEngineeringCenter/cwms-database#123 TODO: - [ ] merge schema update PR - [ ] integration testing - [ ] OpenAPI documentation
Merged
4 tasks
adamkorynta
changed the title
Collaborator
Author
Screenshot for the location search page. |
Collaborator
|
Quick note
I rebuilt and published a newer version of cwmsjs. Saw this was 2 months ago. Might see in the docs If the method you seek is present now? |
Collaborator
Author
This PR is the one adding that query parameter. Kinda chicken-and-egg. |
MikeNeilson
requested changes
May 12, 2026
Contributor
MikeNeilson
left a comment
MikeNeilson
left a comment
There was a problem hiding this comment.
Overall looks good. Couple of nitpicks. And one thing that's just confusing me.
zack-rma
suggested changes
May 12, 2026
Collaborator
zack-rma
left a comment
zack-rma
left a comment
There was a problem hiding this comment.
Some questions and nitpicks
zack-rma
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #288
demonstrating usage of: HydrologicEngineeringCenter/cwms-database#123
Adds a test page for location search. Note: needs a newer version of cwmsjs that supports text search catalog parameter (I tested via hotswapping in the debugger).
TODO: