Fix tqdm crash in TARGET (#116): route progress through QgsProcessingFeedback#142
Open
jixuan-chen wants to merge 1 commit into
Open
Fix tqdm crash in TARGET (#116): route progress through QgsProcessingFeedback#142jixuan-chen wants to merge 1 commit into
jixuan-chen wants to merge 1 commit into
Conversation
…ssingFeedback Requires target-py>=0.2.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #116.
tqdmwrites its progress bar tosys.stdout, which QGIS sets toNonewhen the Python console is not open, crashing withAttributeError: 'NoneType' object has no attribute 'write'(and the same for theloggingcalls in the same run).target-py0.2.0 adds an optionalfeedbackparameter toTarget(...)that routes progress through aQgsProcessingFeedback/QgsFeedbackobject instead oftqdmwhen one is provided. This wires it through intarget_algorithm.py.Requires
target-py>=0.2.0. Companion PR bumping the version pin inumep-reqs: UMEP-dev/umep-reqs#15Tested locally on QGIS 3.40.5 (macOS) by running the TARGET algorithm through the actual Processing Toolbox GUI with
target-py0.2.0 installed.