Conversation
…nf at NexflowModules
…parameter in functions main and save_output
…d choose accordingly
…ionMask, fitting, pvalue and zscore calculation to run outrider
…ate filtering for exon level and ratio fpkm
BasMonkey
left a comment
There was a problem hiding this comment.
Nice work!
Some minor remarks:
- Some files are missing a newline at the end of the file. Why it's important? See https://stackoverflow.com/a/729795
- Try to be consistent with the indentation across your files / code
- See individual files for the remarks per line
Fraser/1.99.3/environment.yml
Outdated
There was a problem hiding this comment.
Missing newline at the end of this file, see https://stackoverflow.com/a/729795
Fraser/1.99.3/fraser.R
Outdated
There was a problem hiding this comment.
Try to avoid print statements, since they might get lost in the stdout. If you want to save / view the data of a variable, write it to a logfile instead
Fraser/1.99.3/fraser.R
Outdated
There was a problem hiding this comment.
Same goes for this print statement
Fraser/1.99.3/fraser.R
Outdated
There was a problem hiding this comment.
Same goes for these print statements aswell
Fraser/1.99.3/fraser.R
Outdated
Outrider/1.20.0/outrider.R
Outdated
There was a problem hiding this comment.
Missing newline at the end of this file
There was a problem hiding this comment.
This is one of the two files that uses two spaces as indentation (instead of four). Try to be consistent throughout your code
Fraser/1.99.3/fraser.R
Outdated
There was a problem hiding this comment.
Try to avoid print statements, since they might get lost in the stdout. If you want to save / view the data of a variable, write it to a logfile instead
There was a problem hiding this comment.
This is one of the two files that uses two spaces as indentation (instead of four). Try to be consistent throughout your code
Outrider/1.20.0/outrider.R
Outdated
There was a problem hiding this comment.
It may be better to fill this path as a parameter or via a config file. The path may change and to include that change a new release of the software must be made. (or worse: this line gets overlooked at all)
| @@ -0,0 +1,19 @@ | |||
| ################## BASE IMAGE ###################### | |||
| FROM --platform=linux/amd64 quay.io/biocontainers/bioconductor-outrider:1.18.1--r43hf17093f_0 | |||
There was a problem hiding this comment.
The base image is using version 1.18.1--r43hf17093f_0. Folder name Outrider/1.20.0/ doesnot match.
Outrider script for RNA seq pipeline in main.nf (main.yml) and outrider.R