Uize.Node.injectHtml, script tags, and Safari

[timcarter]

It looks like there's a bug in Uize.Node.injectHtml in Safari. When trying to inject some markup, only top-level script tags are evaluated. Any nested tags are ignored. This has caused some problems while dynamically loading content (such as a dialog) into a page. I've thrown together a quick demonstration page at: http://timcarter.github.com/bugs/injectscript.html.

On that page, Firefox, Chrome, and IE throw two alerts while Safari throws only one. The first alert is contained in the top-level script tag while the second is nested one level under a

tag.

[UIZE]

What's your recommended fix?

[timcarter]

I've isolated the problem to the _fixCrippledScripts function in Uize.Node.injectHtml. The else-if clause in that function uses Uize.forEach, which in turn only executes the _iterationHandler if the _source parameter is an array, object, or number. In all browsers except Safari, the child node list passed as the _source parameter is an object; in Safari it's a function.

My suggestion is to change the _isObject check in Uize.forEach to use the new canExtend method, similar to how you modified Uize.copyInto last week.

[UIZE]

Tim, thanks for looking into that. I will make the change and commit a fix.