Skip to content

fix readthedocs updating #290

Description

@dave-doty

readthedocs is having errors even though I can compile with Sphinx locally: https://readthedocs.org/projects/scadnano-python-package/builds/22907418/

Activity

  1. rayzhuca commented on Dec 20, 2023

    @rayzhuca
    Contributor

    I think this is due to the new changes that buildthedocs rolled out:
    https://blog.readthedocs.com/use-build-os-config/
    I'll create a new branch that adds the new configs in readthedocs.yml.

  2. dave-doty commented on Dec 21, 2023

    @dave-doty
    MemberAuthor

    Here's the latest error (after fixing the build.os issue in PR #292): https://readthedocs.org/projects/scadnano-python-package/builds/22917882/

    image

  3. linked a pull request that will close this issue290 fix readthedocs updating #293on Dec 21, 2023
  4. rayzhuca commented on Jan 17, 2024

    @rayzhuca
    Contributor
  5. dave-doty commented on Jan 17, 2024

    @dave-doty
    MemberAuthor

    In general we only close issues when they make it to the main branch (that's the main reason to have main be the default branch, so that commit messages with phrases such as "closes #<issue_number>" will automatically close them, but only when that commit makes it to the main branch), but maybe because this involves readthedocs it is already fixed? Essentially let's leave this open until we've fixed the issue totally (i.e., the readthedocs site shows the correct documentation), but I haven't checked to see if it's really fixed yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingclosed in devhigh prioritySomething cruicial to get working soon.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions