refactor(runner): extract test identity and title interpolation#654
Merged
Conversation
Pull the test ID/coverage env exports and the data-provider title interpolation block out of `bashunit::runner::run_test` into named helpers (`export_test_identity`, `apply_interpolated_title`). The helper returns the interpolated name so subsequent code in `run_test` keeps the same local. Pure extraction, no behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Background
Continuing the
run_testslim-down from #653. The opening of the function still inlined two distinct concerns (test ID + coverage env exports, and data-provider title interpolation) before getting to the actual subshell.💡 Changes
bashunit::runner::export_test_identity— setsBASHUNIT_CURRENT_TEST_IDand the coverage env varsbashunit::runner::apply_interpolated_title— handles theinterpolate_function_namebranch and returns the interpolated name so callers can keep using the local