chore(shellcheck): silence intentional SC2016 in coverage tests#651
Merged
Conversation
The two `done` fixtures pass literal `$var`/`$file` strings to `is_executable_line` on purpose; flag them with `# shellcheck disable=SC2016` so `make sa` runs noise-free.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Background
make saprints two SC2016 hints on every run because two coverage tests deliberately pass literal$var/$filestrings as fixtures tois_executable_line. The warnings are noise — the strings are meant to look like raw shell snippets.💡 Changes
# shellcheck disable=SC2016directives next to the two intentional fixtures somake saruns noise-free