Repository navigation
ci: drop the benchmark job's yarn fallback - #1713
Merged
Merged
Conversation
main now has package-lock.json, so every base branch installs with npm ci. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Benchmark (Ubuntu)
PR branch = |
Benchmark (macOS)
PR branch = |
Benchmark (Windows)
PR branch = |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the temporary fallback added in #1712. When the benchmark job's base branch had no
package-lock.json, it installed that base withnpx yarn@1. The fallback only existed so #1712's own benchmark could install the pre-migrationmain.mainnow haspackage-lock.json, so every PR's base installs with plainnpm ci, and the yarn branch can no longer be reached.Testing
This PR's own benchmark job exercises the change, since its base is the post-migration
main.🤖 Generated with Claude Code