Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: d971cab | Previous: d803417 | Ratio |
|---|---|---|---|
BenchmarkWorkspaceCycle (typefox.dev/fastbelt/examples/statemachine) - MB/s |
13 MB/s |
5.21 MB/s |
2.50 |
This comment was automatically generated by workflow using github-action-benchmark.
msujew
force-pushed
the
msujew/semantic-tokens
branch
from
August 6, 2026 12:55
97f005c to
d971cab
Compare
Merged
Lotes
reviewed
Aug 10, 2026
msujew
force-pushed
the
msujew/semantic-tokens
branch
from
August 19, 2026 13:44
d971cab to
0e72789
Compare
Lotes
approved these changes
Aug 25, 2026
Lotes
left a comment
Lotes
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! Looks good. Just some little questions about the legend provider.
Member
There was a problem hiding this comment.
Thanks a lot @msujew for this contribution, too, now I made it through it.
The review done by Claude brought interesting issues up, and I have a few requests for more documentation, see below.
msujew
force-pushed
the
msujew/semantic-tokens
branch
3 times, most recently
from
September 1, 2026 11:06
b409f4d to
eb49559
Compare
msujew
force-pushed
the
msujew/semantic-tokens
branch
from
September 8, 2026 14:30
eb49559 to
b2f2426
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #95
Provides the infrastructure to implement semantic tokens support for any language. Comes with:
AssertSemanticTokens.ExtendableSemanticTokensLegendProvider.SemanticTokensBuilder.TokenHighlightingStrategyandTokenBasedSemanticTokensProvider.