Repository navigation
test/react pdf offline assets - #3269
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Configure test file URL resolver packages/xl-pdf-exporter/src/react-pdf/pdfExporter.test.tsx |
The document export and header/footer export tests pass testResolveFileUrl as the resolveFileUrl option. |
Priority:
Estimated code review effort: 1 (Trivial) | ~4 minutes
Change: Other
Possibly related PRs
- TypeCellOS/BlockNote#3110: Both PRs update PDF exporter test asset resolution.
Suggested reviewers: yousefed
Merge Risk: 
Minimal · up to fa684
-
This test-only change is mergeable and keeps PDF test assets locally resolvable.
Pre-merge checks: 
4 · 
1
-
Failed checks: 1 warning Passed checks: 4 passed-
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.
-
Full details: Description check
-
Explanation
The description clearly states the change, rationale, scope, and test result. It does not follow the repository template because it omits the Rationale, Changes, Impact, Screenshots/Video, Checklist, and Additional Notes sections. The Validation section provides testing information but does not replace the required Testing heading.
Resolution
Update the description to include all template sections. Add explicit Rationale, Changes, Impact, Testing, Screenshots/Video, Checklist, and Additional Notes sections. Mark each checklist item as applicable, and state when screenshots or additional notes are not applicable.
-
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit checks the PDF flow,
Two tests now know which path to go.
A local resolver joins the chase,
No remote image needs a place.
Hop, export, and test with grace.
Comment @coderabbitai help to get the list of available commands.
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/diagram-block
@blocknote/mantine
@blocknote/math-block
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
@blocknote/xl-typst-exporter
commit: |
|
fa684cd to
5a5e89b
Compare
Summary
This PR is independent of #2963 and can merge without the table visualization change.
Validation
vp run test pdfExporter.test.tsxinpackages/xl-pdf-exporter: 2 tests passed.