Skip to content

test/react pdf offline assets - #3269

Merged
nperez0111 merged 1 commit into
mainfrom
test/react-pdf-offline-assets
Oct 28, 2026
Merged

nperez0111 merged 1 commit into
mainfrom
test/react-pdf-offline-assets

Conversation

@nperez0111

@nperez0111 nperez0111 commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Use the existing local test asset resolver in both React PDF exporter tests.
  • Avoid fetching the placeholder image through the external CORS proxy, making these tests independent of network availability.

This PR is independent of #2963 and can merge without the table visualization change.

Validation

  • vp run test pdfExporter.test.tsx in packages/xl-pdf-exporter: 2 tests passed.

@vercel

vercel Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
blocknote Ready Ready Preview Oct 28, 2026 5:37pm UTC
blocknote-website Ready Ready Preview Oct 28, 2026 5:37pm UTC

Request Review

@nperez0111
nperez0111 added this pull request to stack #3270 October 28, 2026 17:19
@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4d862a9b-4666-4fc8-a9fc-269bd9c4e571
Commits

Reviewing files that changed from the base of the PR and between f697d9f and fa684cd.

Files selected for processing: 1
  • packages/xl-pdf-exporter/src/react-pdf/pdfExporter.test.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

The PDF exporter tests now import testResolveFileUrl and pass it to the exporters in the document and header/footer export tests.

Changes: PDF exporter test configuration

Layer / File(s) Summary
Configure test file URL resolver
packages/xl-pdf-exporter/src/react-pdf/pdfExporter.test.tsx
The document export and header/footer export tests pass testResolveFileUrl as the resolveFileUrl option.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Possibly related PRs

Suggested reviewers: yousefed

Merge Risk: Minimal · up to fa684

This test-only change is mergeable and keeps PDF test assets locally resolvable.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The description clearly states the change, rationale, scope, and test result. It does not follow the repository template because it omits the Rationale, Changes, Impact, Screenshots/Video, Checklist, … Update the description to include all template sections. Add explicit Rationale, Changes, Impact, Testing, Screenshots/Video, Checklist, and Additional Notes sections. Mark each checklist item as applicable, and state when screenshots or ad…
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly identifies the main change: updating React PDF tests to use offline assets.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.

Full details: Description check

Explanation

The description clearly states the change, rationale, scope, and test result. It does not follow the repository template because it omits the Rationale, Changes, Impact, Screenshots/Video, Checklist, and Additional Notes sections. The Validation section provides testing information but does not replace the required Testing heading.

Resolution

Update the description to include all template sections. Add explicit Rationale, Changes, Impact, Testing, Screenshots/Video, Checklist, and Additional Notes sections. Mark each checklist item as applicable, and state when screenshots or additional notes are not applicable.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the PDF flow,
Two tests now know which path to go.
A local resolver joins the chase,
No remote image needs a place.
Hop, export, and test with grace.

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

@blocknote/ariakit

npm i https://pkg.pr.new/@blocknote/ariakit@3269

@blocknote/code-block

npm i https://pkg.pr.new/@blocknote/code-block@3269

@blocknote/core

npm i https://pkg.pr.new/@blocknote/core@3269

@blocknote/diagram-block

npm i https://pkg.pr.new/@blocknote/diagram-block@3269

@blocknote/mantine

npm i https://pkg.pr.new/@blocknote/mantine@3269

@blocknote/math-block

npm i https://pkg.pr.new/@blocknote/math-block@3269

@blocknote/react

npm i https://pkg.pr.new/@blocknote/react@3269

@blocknote/server-util

npm i https://pkg.pr.new/@blocknote/server-util@3269

@blocknote/shadcn

npm i https://pkg.pr.new/@blocknote/shadcn@3269

@blocknote/xl-ai

npm i https://pkg.pr.new/@blocknote/xl-ai@3269

@blocknote/xl-docx-exporter

npm i https://pkg.pr.new/@blocknote/xl-docx-exporter@3269

@blocknote/xl-email-exporter

npm i https://pkg.pr.new/@blocknote/xl-email-exporter@3269

@blocknote/xl-multi-column

npm i https://pkg.pr.new/@blocknote/xl-multi-column@3269

@blocknote/xl-odt-exporter

npm i https://pkg.pr.new/@blocknote/xl-odt-exporter@3269

@blocknote/xl-pdf-exporter

npm i https://pkg.pr.new/@blocknote/xl-pdf-exporter@3269

@blocknote/xl-typst-exporter

npm i https://pkg.pr.new/@blocknote/xl-typst-exporter@3269

commit: fa684cd

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://TypeCellOS.github.io/BlockNote/pr-preview/pr-3269/

Built to branch gh-pages at 2026-10-28 17:50 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@nperez0111
nperez0111 removed this pull request from stack #3270 October 28, 2026 17:35
@nperez0111
nperez0111 changed the base branch from table-reordering-visualization to main October 28, 2026 17:35
@nperez0111
nperez0111 force-pushed the test/react-pdf-offline-assets branch from fa684cd to 5a5e89b Compare October 28, 2026 17:35
@nperez0111
nperez0111 merged commit 736e9ea into main Oct 28, 2026
11 of 14 checks passed
@nperez0111
nperez0111 deleted the test/react-pdf-offline-assets branch October 28, 2026 17:35

This branch was successfully deployed

2 active deployments
Preview – blocknote-website — 5a5e89b0 Deployed Oct 28, 2026 by vercel[bot]
Preview – blocknote — 5a5e89b0 Deployed Oct 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant