Repository navigation
feat(calls): 複数の画面共有と共有音声ごとの音量調整に対応 - #72
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 25 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (17)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
このPRによるapi.jsonの差分 差分はこちら--- base
+++ head
@@ -28653,6 +28653,10 @@
"screen"
]
},
+ "screenPublicationId": {
+ "type": "string",
+ "format": "id"
+ },
"mediaKind": {
"type": "string",
"enum": [
@@ -30343,6 +30347,10 @@
],
"default": "microphone"
},
+ "screenPublicationId": {
+ "type": "string",
+ "format": "misskey:id"
+ },
"mid": {
"type": "string",
"minLength": 1, |
🖥 Frontend Diagnostics Report(No significant changes) Requests by resource type
V8 heap snapshot statistics
📦 Bundle StatsChunk size diff (2 updated, 0 added, 0 removed)
Startup chunk size (0 updated, 0 added, 0 removed)
Startup chunks are the Vite entry for
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
⚙️ Backend Diagnostics ReportMemory: After GC(No significant changes) V8 Heap Snapshot Statistics
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
1人が複数の画面・ウィンドウを同時に共有できるようにしました。共有設定から追加・個別停止でき、ブラウザの共有選択画面で音声を含めるか選べます。受信側は各共有映像と別ウィンドウのスライダーで、共有音声の音量をマイクとは独立して調整できます。
Why
複数の画面を同時に見せつつ、共有ごとの音声を必要に応じて聞き分けるため。ユーザーからの依頼による変更です。対応する既存Issueは見つかりませんでした。
Additional info (optional)
共有音声は自分の接続世代の画面共有publicationに紐付けて公開し、共有終了時には映像・音声を閉じます。既存の共有権限制御を維持しています。DBスキーマの変更はなく、既存の一時publication bindingに対応関係を追加しています。
sequenceDiagram participant Sender as 共有する人 participant Browser as ブラウザ participant API as Calls API participant Receiver as 聞く人 Sender->>Browser: 共有対象と音声の有無を選択 Browser->>API: 画面映像を公開 API-->>Browser: publicationId opt 共有音声がある Browser->>API: 映像publicationIdに紐付けて音声を公開 end Receiver->>API: publicationを取得・購読 Receiver->>Receiver: 共有ごとの音量を調整検証:
pnpm build-misskey-js-with-types、node scripts/check-shipping.mjs（変更ファイルlint、SPDX、locale safety）。Tsx呼び出しやFastifyの拡張型など、今回変更していない箇所にも型エラーが出ています。CHANGELOGは指示に従って未変更。候補: 複数画面の同時共有と、共有音声ごとの音量調整に対応。
Checklist