fix: Exclude .md files from fleet resource scope resolution#29
Merged
Conversation
Markdown files (READMEs, docs) under resource dirs like policies/, labels/, scripts/ were incorrectly treated as fleet config, causing docs-only MRs to trigger full API diffs with unrelated changes. Ref #28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.mdfiles under resource dirs (policies/README.md,labels/README.md, etc.) were treated as fleet config by scope resolutionlabels/README.mdincorrectly setIncludeGlobal = true, triggering a full API diffpolicies/README.mdetc. matchedisFleetResource(), triggering team lookupsFix
Exclude
.mdfiles fromisFleetResource()and thelabels/global trigger inResolveScope.Test plan
labels/README.md does not set IncludeGlobalREADME under resource dir ignoredisFleetResourcecases for*/README.md(all 5 resource dirs)Ref #28