Skip to content

Add server-backed favourites and URL-controlled Search filtering - #113

Open
TrySound wants to merge 4 commits into
mainfrom
feat/favourites-search-110
Open

TrySound wants to merge 4 commits into
mainfrom
feat/favourites-search-110

Conversation

@TrySound

@TrySound TrySound commented Nov 11, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Add independent server-backed artist, album and track favourites, with validated OpenSubsonic endpoints, server-confirmed edits, reconciliation after uncertain writes, and account-scoped cached descriptions.
  • Extend main’s existing URL-controlled Search with an independent Favourites toggle. It intersects existing q, repeated type, and downloaded-only filters; no text directives, custom favourites page, extra router state, or draft store.
  • Append favourite toggles after Download in existing Library/detail/Search menus; successful toggles update in place. Now Playing has Queue on the left, centered transport, and a direct favourite button on the right—no Actions popover. Pending/errors appear inline.
  • Keep authenticated favourites refresh/editing independent of downloaded-only browsing. Preserve corrupt caches and distinguish device checkpoint failures from server success; integrate main’s optional disconnect cleanup.

Closes #110.

Rebased onto origin/main at dbd51ec, retaining the latest keyed Search groups and deferred trailing-batch rendering. Search integration follows the updated URL/type design on main, superseding this PR’s earlier colon-directive and encoded-search-path design. No Home, Library rename, navigation redesign, listen-later list or offline mutation outbox.

Search URLs

  • ?/search&favourite=1 — browse the user’s starred artists, albums and tracks.
  • ?/search&type=track&favourite=1&q=hello — starred tracks matching text.
  • Type filters combine with OR; favourites/text/download eligibility combine with AND. Type/modifier toggles push history; text edits replace it. Reload and Back/Forward restore the URL-derived controls/results.
  • Reuse main’s grouped previews and single-type batching/rendering. Retained unavailable favourites remain removable, without enabled playback/detail/download targets.

Validation

  • pnpm check — passed, zero errors; existing App autofocus warning remains.
  • pnpm test — 1,273 tests passed, independently rerun after the latest rebase.
  • App, website and /webapp/ production builds — passed.
  • Mocked-server Chromium production browser suites — 3 root / 3 subpath tests passed, covering Search rendering, favourites, menu/player lifecycle and URL navigation. Suites ran serially.
  • Coverage includes URL combinations/literal text/special characters/hash/history/reload; every favourite action context; unavailable records; pending removals; stale/disappearing targets and focus; downloaded-only authenticated actions; in-flight disconnect/storage failures; and optional local-cache deletion.
  • Fresh independent code review and rendered desktop/mobile design review accepted; git diff --check passed.

Simplicity

  • One active Search index; ordinary Search does not read favourite membership or reset expanded results after a star/refresh. Text/type edits do not rebuild snapshots unnecessarily.
  • Removed scripted focus restoration, focus-only refs, invoker tracking, overlay-opening generations, shared-button effects and async success dismissal. Native user dismissal owns focus; favourite menu toggles stay open.
  • Only four narrow orphan-selection effects remain to close genuinely empty menus after external data/filter changes, without moving focus.
  • Required typed domain props, one pending-intent Map, captured-target/cache failure isolation and domain safety remain. No new dependencies, compatibility aliases, management framework or competing Search state source.
  • Regressions cover 13-row/70-row pagination retention, pending completion without focus theft, menu reopening, player track changes, same-ID cache replacement and native keyboard dismissal.

Limitations

  • Live Navidrome/second-client compatibility, physical Safari/iOS/installed-app behavior, physical-device storage durability and calibrated screen-reader output remain unverified. Browser coverage uses mocked transport with Chromium/native OPFS.
  • Legacy artist/album records require a Library refresh before adding stars; retained server favourites remain removable. Demo favourite operations explicitly fail without breaking browsing/playback.
  • Unreadable favourite documents are preserved until explicit local-data cleanup rather than silently overwritten. The protocol provides no atomic cross-client revision guarantee.
  • Preexisting dense track metadata at 320px/enlarged text and optional Search attention-surface polish are outside this change.

@TrySound
TrySound force-pushed the feat/favourites-search-110 branch from 3d7f1ff to 4be5110 Compare November 16, 2026 16:31
@TrySound TrySound changed the title Add server-backed favourites, Search directives, and menu actions Add server-backed favourites and URL-controlled Search filtering Nov 16, 2026
@TrySound
TrySound force-pushed the feat/favourites-search-110 branch from a114ba4 to d249ecd Compare November 16, 2026 17:52

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add server-backed favourites, Search directives, and menu actions

1 participant