Updated Renovate config to ignore pinned pnpm override deps - #29583
Conversation
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run ghost-monorepo:lint:boundaries |
✅ Succeeded | <1s | View ↗ |
nx run-many -t lint -p ghost-monorepo |
✅ Succeeded | <1s | View ↗ |
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗
☁️ Nx Cloud last updated this comment at 2026-07-24 22:25:38 UTC
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughUpdated Renovate’s 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ref #29092 ref #29099 - `ignoreDeps: ["knex"]` does not match the pnpm override key `knex-migrator>knex`, so Renovate kept proposing knex 2.5.x through the override despite the PLA-78 pin — #29092 broke bootstrap migrations - the `path-to-regexp@<0.1.13` override exists only to force Express 4's transitive dep to the ReDoS-patched 0.1.13; 0.2.x+ breaks Express 4 routing, so bumps across that boundary (#29099) are never valid
26370e6 to
9843ea6
Compare

Two Renovate PRs recently proposed bumps through pnpm overrides that are intentional pins, because
ignoreDepsmatches package names, not override keys:knex-migrator>knex— the existing"knex"ignore (PLA-78 pin to 2.4.2, in lockstep with ghost/core's knex) doesn't match the override key, so Renovate proposed 2.5.1 (Update dependency knex-migrator>knex to v2.5.1 #29092), which breaks bootstrap migrations (2.4.2 query builder compiled by a 2.5.1 compiler).path-to-regexp— thepath-to-regexp@<0.1.13override exists only to force Express 4's transitive dep to the ReDoS-patched 0.1.13. Express 4 pins path-to-regexp 0.1.x; the proposed^0.2.0(Update dependency path-to-regexp@<0.1.13 to ^0.2.0 #29099) breaks route matching (its own CI showed the click-tracking redirect test failing).Adds both to
ignoreDepsso these unactionable bumps stop recurring.Verification
node -e "require('json5').parse(...)"parses clean.