Skip to content

Updated Renovate config to ignore pinned pnpm override deps - #29583

Merged
9larsons merged 1 commit into
mainfrom
renovate-ignore-override-keys
Jul 25, 2026
Merged

Updated Renovate config to ignore pinned pnpm override deps#29583
9larsons merged 1 commit into
mainfrom
renovate-ignore-override-keys

Conversation

@9larsons

Copy link
Copy Markdown
Contributor

Two Renovate PRs recently proposed bumps through pnpm overrides that are intentional pins, because ignoreDeps matches package names, not override keys:

  • knex-migrator>knex — the existing "knex" ignore (PLA-78 pin to 2.4.2, in lockstep with ghost/core's knex) doesn't match the override key, so Renovate proposed 2.5.1 (Update dependency knex-migrator>knex to v2.5.1 #29092), which breaks bootstrap migrations (2.4.2 query builder compiled by a 2.5.1 compiler).
  • path-to-regexp — the path-to-regexp@<0.1.13 override exists only to force Express 4's transitive dep to the ReDoS-patched 0.1.13. Express 4 pins path-to-regexp 0.1.x; the proposed ^0.2.0 (Update dependency path-to-regexp@<0.1.13 to ^0.2.0 #29099) breaks route matching (its own CI showed the click-tracking redirect test failing).

Adds both to ignoreDeps so these unactionable bumps stop recurring.

Verification

  • Config-only change; node -e "require('json5').parse(...)" parses clean.

@nx-cloud

nx-cloud Bot commented Jul 24, 2026

Copy link
Copy Markdown

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci


View your CI Pipeline Execution ↗ for commit 26370e6

Command Status Duration Result
nx run ghost-monorepo:lint:boundaries ✅ Succeeded <1s View ↗
nx run-many -t lint -p ghost-monorepo ✅ Succeeded <1s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-07-24 22:25:38 UTC

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 6a0720d8-a42f-40e8-b56f-5bb1f56cf905

📥 Commits

Reviewing files that changed from the base of the PR and between 26370e6 and 9843ea6.

📒 Files selected for processing (1)
  • .github/renovate.json5
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/renovate.json5

Walkthrough

Updated Renovate’s ignoreDeps configuration to retain knex, add knex-migrator>knex, and ignore path-to-regexp so the configured dependency overrides remain effective.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly reflects the main change: updating Renovate to ignore pinned pnpm override dependencies.
Description check ✅ Passed The description is directly related to the config-only Renovate update and explains the ignored override dependencies.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch renovate-ignore-override-keys

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

ref #29092
ref #29099

- `ignoreDeps: ["knex"]` does not match the pnpm override key
  `knex-migrator>knex`, so Renovate kept proposing knex 2.5.x through the
  override despite the PLA-78 pin — #29092 broke bootstrap migrations
- the `path-to-regexp@<0.1.13` override exists only to force Express 4's
  transitive dep to the ReDoS-patched 0.1.13; 0.2.x+ breaks Express 4
  routing, so bumps across that boundary (#29099) are never valid
@9larsons
9larsons force-pushed the renovate-ignore-override-keys branch from 26370e6 to 9843ea6 Compare July 24, 2026 22:23
@9larsons
9larsons merged commit 9b51657 into main Jul 25, 2026
33 checks passed
@9larsons
9larsons deleted the renovate-ignore-override-keys branch July 25, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant