Skip to content

Clarify My Ships ESI prompts as scope grants, not Auth re-registration - #138

Merged
TrueMessenger merged 1 commit into
mainfrom
fix/esi-grant-wording
Jul 8, 2026
Merged

TrueMessenger merged 1 commit into
mainfrom
fix/esi-grant-wording

Conversation

@TrueMessenger

Copy link
Copy Markdown
Owner

Summary

  • The blocked-characters warning on My Ships now explains that Fit Check needs an extra ESI grant to read the listed characters' ship hangars, and that this is separate from the character's Auth registration (which is unaffected) - the previous "These characters need ESI access" + "Connect ESI access" wording read as if the character had to be re-registered with Auth.
  • The warning's button is now "Grant access for N character(s)" (pluralized via blocktranslate count).
  • The info banner's button and the filter-bar shortcut now say "Grant" instead of "Connect".

Test plan

  • manage.py test fitcheck - 833 tests pass
  • manage.py check clean; makemigrations fitcheck --check --dry-run - no changes
  • Text-only template change; the visibility conditions and grant URL are untouched (existing TestConnectEsiVisibility assertions pin both).

The blocked-characters warning and its button read as if the character
had to be reconnected to Auth. The warning now explains Fit Check needs
an extra ESI grant separate from the Auth registration, the button
carries the affected character count (pluralized), and the remaining
prompts say Grant instead of Connect.
@TrueMessenger
TrueMessenger merged commit ad2cb78 into main Jul 8, 2026
@TrueMessenger
TrueMessenger deleted the fix/esi-grant-wording branch July 8, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant